Skip to content

Conversation

@AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Jun 19, 2025

  • Add support for ceil_mode=True for avgpool and maxpool
  • Add support for count_include_pad==True for avgpool
  • Add support for divisor_override for avgpool
  • Fix padding check in pool_2d_support

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Add support for ceil_mode=True for avgpool and maxpool
- Add support for count_include_pad==True for avgpool
- Add support for divisor_override for avgpool
- Fix padding check in pool_2d_support

Signed-off-by: Adrian Lundell <[email protected]>
Change-Id: I4e4ec8ebaf174279893b640f87b691ea03cb668d
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing release notes: arm Changes to the ARM backend delegate labels Jun 19, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11819

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 2 Unrelated Failures

As of commit acdca0c with merge base 994752e (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 19, 2025
@zingo zingo merged commit 91dfd62 into pytorch:main Jun 19, 2025
194 of 197 checks passed
@cccclai
Copy link
Contributor

cccclai commented Jun 19, 2025

Test under executorch/backends/arm/test/avg_pool2d is failing as fyi

@zingo
Copy link
Collaborator

zingo commented Jun 21, 2025

Test under executorch/backends/arm/test/avg_pool2d is failing as fyi

Thanks for reporting!
I tried to find the failing test but could not find it, do you have a link where we can check.

hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
- Add support for ceil_mode=True for avgpool and maxpool
- Add support for count_include_pad==True for avgpool
- Add support for divisor_override for avgpool
- Fix padding check in pool_2d_support

Signed-off-by: Adrian Lundell <[email protected]>
@AdrianLundell AdrianLundell deleted the change-1057031 branch September 4, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants