Skip to content

Remove is_arvr_mode() from xplat/executorch/runtime/core/portable_type/c10/c10/targets.bzl #11830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Remove is_arvr_mode() from xplat/executorch/runtime/core/portable_type/c10/c10/targets.bzl #11830

merged 1 commit into from
Jun 25, 2025

Conversation

@mchien512
Copy link
Contributor

@mchien512 mchien512 commented Jun 20, 2025

Summary:
Remove is_arvr_mode() from fbcode/executorch/runtime/core/portable_type/c10/c10/targets.bzl.

This is an effort to unify the xplat and rl target graphs in the citadel orchestrator
See post for context https://fb.workplace.com/groups/3454295018049629/permalink/3734068433405618/

Reviewed By: autozimu

Differential Revision: D76755925

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11830

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b32bfb6 with merge base 44ab83a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 20, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 20, 2025

This pull request was exported from Phabricator. Differential Revision: D76755925

@github-actions
Copy link

github-actions bot commented Jun 20, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mchien512 mchien512 force-pushed the export-D76755925 branch 3 times, most recently from 8ad5ef6 to 12ffb17 Compare June 23, 2025 22:00
mchien512 pushed a commit to mchien512/executorch that referenced this pull request Jun 23, 2025
@facebook-github-bot
Remove is_arvr_mode() from xplat/executorch/runtime/core/portable_typ…
12ffb17 
…e/c10/c10/targets.bzl (pytorch#11830)

Summary:

Remove is_arvr_mode() from fbcode/executorch/runtime/core/portable_type/c10/c10/targets.bzl.

This is an effort to unify the xplat and rl target graphs in the citadel orchestrator
See post for context https://fb.workplace.com/groups/3454295018049629/permalink/3734068433405618/

Reviewed By: autozimu, swolchok

Differential Revision: D76755925
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 23, 2025

This pull request was exported from Phabricator. Differential Revision: D76755925

mchien512 pushed a commit to mchien512/executorch that referenced this pull request Jun 23, 2025
@facebook-github-bot
Remove is_arvr_mode() from xplat/executorch/runtime/core/portable_typ…
f7679d9 
…e/c10/c10/targets.bzl (pytorch#11830)

Summary:

Remove is_arvr_mode() from fbcode/executorch/runtime/core/portable_type/c10/c10/targets.bzl.

This is an effort to unify the xplat and rl target graphs in the citadel orchestrator
See post for context https://fb.workplace.com/groups/3454295018049629/permalink/3734068433405618/

Reviewed By: autozimu, swolchok

Differential Revision: D76755925
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 23, 2025

This pull request was exported from Phabricator. Differential Revision: D76755925

@facebook-github-bot
Remove is_arvr_mode() from xplat/executorch/runtime/core/portable_typ…
b32bfb6 
…e/c10/c10/targets.bzl (pytorch#11830)

Summary:

Remove is_arvr_mode() from fbcode/executorch/runtime/core/portable_type/c10/c10/targets.bzl.

This is an effort to unify the xplat and rl target graphs in the citadel orchestrator
See post for context https://fb.workplace.com/groups/3454295018049629/permalink/3734068433405618/

Reviewed By: autozimu, swolchok

Differential Revision: D76755925
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 24, 2025

This pull request was exported from Phabricator. Differential Revision: D76755925

@facebook-github-bot facebook-github-bot merged commit c70047f into pytorch:main Jun 25, 2025
98 of 99 checks passed
@mchien512 mchien512 deleted the export-D76755925 branch June 25, 2025 18:02
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
@mchien512 @hinriksnaer
Remove is_arvr_mode() from xplat/executorch/runtime/core/portable_typ…
e656000 
…e/c10/c10/targets.bzl

Differential Revision: D76755925

Pull Request resolved: pytorch#11830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

1 more reviewer

@swolchok swolchok swolchok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mchien512 @facebook-github-bot @swolchok