Fix apple benchmark app installation issue caused by not installing sentencepiece #11834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entencepiece
Now compiling `text_llm_runner.cpp` requires a dependency to `libsentencepiece.a` and Xcode requires that library to be installed
at a directory in ${TEMP_DIR}/cmake/lib
For example on my laptop:
```
/Users/larryliu/Library/Developer/Xcode/DerivedData/Benchmark-dvseychddztwtucwgxpumwmyedfh/Build/Intermediates.noindex/Benchmark.build/Release-iphoneos/Tests.build/cmake/lib
```
Currently we don't install sentencepiece, this PR changes it to install it.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11834
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit bbbd91c with merge base 496cb05 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
added
the
release notes: none
Contributor
|
Is this also applicable to the LLaMA demo app? |
Contributor
Author
Yep you are right, let me add that |
shoumikhin
approved these changes
Jun 20, 2025
guangy10
approved these changes
Jun 20, 2025
Contributor
guangy10
left a comment
guangy10
left a comment
There was a problem hiding this comment.
Apple / build-benchmark-app passed. Accepted to unblock continuous benchmarking
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
Jun 26, 2025
…entencepiece (pytorch#11834) Currently compiling `text_llm_runner.cpp` requires a dependency to `libsentencepiece.a` and Xcode requires that library to be installed at a directory in ${TEMP_DIR}/cmake/lib For example on my laptop: ``` /Users/larryliu/Library/Developer/Xcode/DerivedData/Benchmark-dvseychddztwtucwgxpumwmyedfh/Build/Intermediates.noindex/Benchmark.build/Release-iphoneos/Tests.build/cmake/lib ``` Before we don't install sentencepiece, this PR changes it to install it. To see the diff clearly: use this link https://www.internalfb.com/intern/diffing/?paste_number=1846901681 <img width="2446" alt="Screenshot 2025-06-20 at 2 28 19 PM" src="https://github.com/user-attachments/assets/3d316b92-c2f9-44ae-9c77-b70f81314224" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently compiling
text_llm_runner.cpprequires a dependency tolibsentencepiece.aand Xcode requires that library to be installedat a directory in ${TEMP_DIR}/cmake/lib
For example on my laptop:
Before we don't install sentencepiece, this PR changes it to install it.
To see the diff clearly: use this link https://www.internalfb.com/intern/diffing/?paste_number=1846901681