Added mse range setting #11857
Merged
Added mse range setting #11857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11857
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled JobsAs of commit 83dc888 with merge base 2f55193 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77055545 |
This PR needs a
|
rohansjoshi
force-pushed
the
export-D77055545
branch
from
74f00b7 to
f7b1ecf
Compare
rohansjoshi
added a commit
to rohansjoshi/executorch
that referenced
this pull request
Jul 4, 2025
Summary: Added option to use MSE range setting algorithm. This algorithm does a linear grid search over scales and selects those which minimizes mean squared error (see the line_search method in the class PerChannelParamsObserver). This method is applied for quantizing weights per channel. On wikitext task: | Model Name | max_seq_len | ptq | range_setting | word_perplexity |----------|----------|----------|-----------|-----------| | Llama 3.2-1B Instruct | 1024 | 16a4w | MinMax | 184.06065814138435 | | Llama 3.2-1B Instruct | 1024 | 16a4w | MSE (grid size 200) | 292.199408962586 | Reviewed By: cccclai Differential Revision: D77055545
|
This pull request was exported from Phabricator. Differential Revision: D77055545 |
cccclai
approved these changes
Jul 4, 2025
rohansjoshi
added a commit
to rohansjoshi/executorch
that referenced
this pull request
Jul 6, 2025
Summary: Added option to use MSE range setting algorithm. This algorithm does a linear grid search over scales and selects those which minimizes mean squared error (see the line_search method in the class PerChannelParamsObserver). This method is applied for quantizing weights per channel. On wikitext task: | Model Name | max_seq_len | ptq | range_setting | word_perplexity |----------|----------|----------|-----------|-----------| | Llama 3.2-1B Instruct | 1024 | 16a4w | MinMax | 184.06065814138435 | | Llama 3.2-1B Instruct | 1024 | 16a4w | MSE (grid size 200) | 292.199408962586 | Reviewed By: cccclai Differential Revision: D77055545
rohansjoshi
force-pushed
the
export-D77055545
branch
from
f7b1ecf to
83e056f
Compare
Summary: Pull Request resolved: pytorch#11857 Added option to use MSE range setting algorithm. This algorithm does a linear grid search over scales and selects those which minimizes mean squared error (see the line_search method in the class PerChannelParamsObserver). This method is applied for quantizing weights per channel. On wikitext task: | Model Name | max_seq_len | ptq | range_setting | word_perplexity |----------|----------|----------|-----------|-----------| | Llama 3.2-1B Instruct | 1024 | 16a4w | MinMax | 184.06065814138435 | | Llama 3.2-1B Instruct | 1024 | 16a4w | MSE (grid size 200) | 292.199408962586 | Reviewed By: cccclai Differential Revision: D77055545
|
This pull request was exported from Phabricator. Differential Revision: D77055545 |
rohansjoshi
force-pushed
the
export-D77055545
branch
from
83e056f to
83dc888
Compare
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
Differential Revision: D77055545 Pull Request resolved: pytorch#11857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added option to use MSE range setting algorithm. This algorithm does a linear grid search over scales and selects those which minimizes mean squared error (see the line_search method in the class PerChannelParamsObserver). This method is applied for quantizing weights per channel. Accuracy is still poor, but somewhat better than using MinMax.
On wikitext task, with grid size 200:
Reviewed By: cccclai
Differential Revision: D77055545