Expose a method getter api in Module #11929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11929
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled JobAs of commit b33dbfe with merge base e1db341 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77248983 |
This PR needs a
|
JacobSzwejbka
changed the title
JacobSzwejbka
force-pushed
the
export-D77248983
branch
from
7517619 to
344cdc3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77248983 |
larryliu0820
approved these changes
Jul 1, 2025
JacobSzwejbka
force-pushed
the
export-D77248983
branch
from
344cdc3 to
2f37caf
Compare
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Jul 14, 2025
Summary: It is sometimes useful for modules to be passed around in user space for user convenience, but for utilities those users interact with to operate on the methods directly. This is a bit of a layering violation but it allows us to define narrower scoped helpers so I think its worth the risk that the user finds a way to trash the internal method object. In general method should be fairly robust to being trashed anyway since itself is a blessed front end api from the team. Reviewed By: larryliu0820 Differential Revision: D77248983
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77248983 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Jul 14, 2025
Summary: It is sometimes useful for modules to be passed around in user space for user convenience, but for utilities those users interact with to operate on the methods directly. This is a bit of a layering violation but it allows us to define narrower scoped helpers so I think its worth the risk that the user finds a way to trash the internal method object. In general method should be fairly robust to being trashed anyway since itself is a blessed front end api from the team. Reviewed By: larryliu0820 Differential Revision: D77248983
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Jul 14, 2025
Summary: It is sometimes useful for modules to be passed around in user space for user convenience, but for utilities those users interact with to operate on the methods directly. This is a bit of a layering violation but it allows us to define narrower scoped helpers so I think its worth the risk that the user finds a way to trash the internal method object. In general method should be fairly robust to being trashed anyway since itself is a blessed front end api from the team. Reviewed By: larryliu0820 Differential Revision: D77248983
JacobSzwejbka
force-pushed
the
export-D77248983
branch
from
2f37caf to
8bfd554
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77248983 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Jul 14, 2025
Summary: It is sometimes useful for modules to be passed around in user space for user convenience, but for utilities those users interact with to operate on the methods directly. This is a bit of a layering violation but it allows us to define narrower scoped helpers so I think its worth the risk that the user finds a way to trash the internal method object. In general method should be fairly robust to being trashed anyway since itself is a blessed front end api from the team. Reviewed By: larryliu0820 Differential Revision: D77248983
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Jul 14, 2025
Summary: Pull Request resolved: pytorch#11929 It is sometimes useful for modules to be passed around in user space for user convenience, but for utilities those users interact with to operate on the methods directly. This is a bit of a layering violation but it allows us to define narrower scoped helpers so I think its worth the risk that the user finds a way to trash the internal method object. In general method should be fairly robust to being trashed anyway since itself is a blessed front end api from the team. Differential Revision: D77248983 Reviewed By: larryliu0820
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Jul 14, 2025
Summary: It is sometimes useful for modules to be passed around in user space for user convenience, but for utilities those users interact with to operate on the methods directly. This is a bit of a layering violation but it allows us to define narrower scoped helpers so I think its worth the risk that the user finds a way to trash the internal method object. In general method should be fairly robust to being trashed anyway since itself is a blessed front end api from the team. bypass-pytorch-export-checks bypass-github-export-checks Reviewed By: larryliu0820 Differential Revision: D77248983
JacobSzwejbka
force-pushed
the
export-D77248983
branch
from
4807ebe to
58980cd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77248983 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Jul 14, 2025
Summary: It is sometimes useful for modules to be passed around in user space for user convenience, but for utilities those users interact with to operate on the methods directly. This is a bit of a layering violation but it allows us to define narrower scoped helpers so I think its worth the risk that the user finds a way to trash the internal method object. In general method should be fairly robust to being trashed anyway since itself is a blessed front end api from the team. bypass-pytorch-export-checks bypass-github-export-checks Reviewed By: larryliu0820 Differential Revision: D77248983
JacobSzwejbka
force-pushed
the
export-D77248983
branch
from
58980cd to
330f2fb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77248983 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Jul 14, 2025
Summary: It is sometimes useful for modules to be passed around in user space for user convenience, but for utilities those users interact with to operate on the methods directly. This is a bit of a layering violation but it allows us to define narrower scoped helpers so I think its worth the risk that the user finds a way to trash the internal method object. In general method should be fairly robust to being trashed anyway since itself is a blessed front end api from the team. bypass-pytorch-export-checks bypass-github-export-checks Reviewed By: larryliu0820 Differential Revision: D77248983
JacobSzwejbka
force-pushed
the
export-D77248983
branch
from
330f2fb to
e504d5a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77248983 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Jul 15, 2025
Summary: It is sometimes useful for modules to be passed around in user space for user convenience, but for utilities those users interact with to operate on the methods directly. This is a bit of a layering violation but it allows us to define narrower scoped helpers so I think its worth the risk that the user finds a way to trash the internal method object. In general method should be fairly robust to being trashed anyway since itself is a blessed front end api from the team. Reviewed By: larryliu0820 Differential Revision: D77248983
Summary: It is sometimes useful for modules to be passed around in user space for user convenience, but for utilities those users interact with to operate on the methods directly. This is a bit of a layering violation but it allows us to define narrower scoped helpers so I think its worth the risk that the user finds a way to trash the internal method object. In general method should be fairly robust to being trashed anyway since itself is a blessed front end api from the team. Reviewed By: larryliu0820 Differential Revision: D77248983
JacobSzwejbka
force-pushed
the
export-D77248983
branch
from
e504d5a to
b33dbfe
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77248983 |
lucylq
pushed a commit
that referenced
this pull request
Jul 17, 2025
Differential Revision: D77248983 Pull Request resolved: #11929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It is sometimes useful for modules to be passed around in user space for user convenience, but for utilities those users interact with to operate on the methods directly.
This is a bit of a layering violation but it allows us to define narrower scoped helpers so I think its worth the risk that the user finds a way to trash the internal method object. In general method should be fairly robust to being trashed anyway since itself is a blessed front end api from the team.
Differential Revision: D77248983