Fix the math in the FuseMulTensorIntoQuantPass. #11946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11946
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bf31998 with merge base 083663b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77267667 |
eigen-k
force-pushed
the
export-D77267667
branch
from
4b99590 to
3feb79d
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Jun 25, 2025
Summary: The new scale value was calculated incorrectly, fixing that with this diff. See the details of the new scale calculation in the comments in the pass. Differential Revision: D77267667
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Jun 25, 2025
Summary: The new scale value was calculated incorrectly, fixing that with this diff. See the details of the new scale calculation in the comments in the pass. Differential Revision: D77267667
eigen-k
force-pushed
the
export-D77267667
branch
from
3feb79d to
a207d64
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77267667 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Jun 25, 2025
Summary: Pull Request resolved: pytorch#11946 The new scale value was calculated incorrectly, fixing that with this diff. See the details of the new scale calculation in the comments in the pass. Differential Revision: D77267667
eigen-k
force-pushed
the
export-D77267667
branch
from
a207d64 to
05dc8a6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77267667 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Jun 25, 2025
Summary: Pull Request resolved: pytorch#11946 The new scale value was calculated incorrectly, fixing that with this diff. See the details of the new scale calculation in the comments in the pass. Differential Revision: D77267667
eigen-k
force-pushed
the
export-D77267667
branch
2 times, most recently
from
9a4fbe5 to
d9dc517
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Jun 26, 2025
Summary: The new scale value was calculated incorrectly, fixing that with this diff. See the details of the new scale calculation in the comments in the pass. Differential Revision: D77267667
eigen-k
force-pushed
the
export-D77267667
branch
from
d9dc517 to
b4b395f
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Jun 26, 2025
Summary: The new scale value was calculated incorrectly, fixing that with this diff. See the details of the new scale calculation in the comments in the pass. Reviewed By: abeakkas Differential Revision: D77267667
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77267667 |
eigen-k
force-pushed
the
export-D77267667
branch
from
b4b395f to
ce750b8
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Jun 26, 2025
Summary: Pull Request resolved: pytorch#11946 The new scale value was calculated incorrectly, fixing that with this diff. See the details of the new scale calculation in the comments in the pass. Reviewed By: abeakkas Differential Revision: D77267667
eigen-k
force-pushed
the
export-D77267667
branch
from
ce750b8 to
e2bca18
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Jun 26, 2025
Summary: The new scale value was calculated incorrectly, fixing that with this diff. See the details of the new scale calculation in the comments in the pass. Reviewed By: abeakkas Differential Revision: D77267667
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77267667 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77267667 |
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Jun 26, 2025
Summary: Pull Request resolved: pytorch#11946 The new scale value was calculated incorrectly, fixing that with this diff. See the details of the new scale calculation in the comments in the pass. Reviewed By: abeakkas Differential Revision: D77267667
eigen-k
force-pushed
the
export-D77267667
branch
from
e2bca18 to
a939402
Compare
zonglinpeng
approved these changes
Jun 30, 2025
eigen-k
force-pushed
the
export-D77267667
branch
from
a939402 to
c8869f7
Compare
eigen-k
added a commit
to eigen-k/executorch
that referenced
this pull request
Jun 30, 2025
Summary: The new scale value was calculated incorrectly, fixing that with this diff. See the details of the new scale calculation in the comments in the pass. Reviewed By: zonglinpeng, abeakkas Differential Revision: D77267667
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77267667 |
Summary: The new scale value was calculated incorrectly, fixing that with this diff. See the details of the new scale calculation in the comments in the pass. Reviewed By: zonglinpeng, abeakkas Differential Revision: D77267667
eigen-k
force-pushed
the
export-D77267667
branch
from
c8869f7 to
bf31998
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77267667 |
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
Differential Revision: D77267667 Pull Request resolved: pytorch#11946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The new scale value was calculated incorrectly, fixing that with this diff. See the details of the new scale calculation in the comments in the pass.
Differential Revision: D77267667