Skip to content

Conversation

@perheld
Copy link
Collaborator

@perheld perheld commented Jun 25, 2025

The vela compiler supports the option to specify a custom vela.ini file. But none of the scripts in the arm backend handles this option and forwards it to vela.

Previous to this commit this was always hardcoded to "Arm/vela.ini"

Now this can be specified with --config that is being forwarded to vela for the following scripts:

  • examples/arm/run.sh
  • examples/arm/aot_arm_compiler.py

While keeping the default of "Arm/vela.ini" in test/common to not break CI.

Change-Id: I5ab25f1784006df96a1e10f97c994024362875da
Signed-off-by: [email protected]

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@perheld perheld requested a review from digantdesai as a code owner June 25, 2025 05:37
@perheld perheld added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Jun 25, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11958

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 78c4c73 with merge base 5335eeb (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2025
The vela compiler supports the option to specify a custom vela.ini
file. But none of the scripts in the arm backend handles this option
and forwards it to vela.

Previous to this commit this was always hardcoded to "Arm/vela.ini"

Now this can be specified with --config that is being forwarded to
vela for the following scripts:
  * examples/arm/run.sh
  * examples/arm/aot_arm_compiler.py

While keeping the default of "Arm/vela.ini" in test/common to not
break CI.

Change-Id: I5ab25f1784006df96a1e10f97c994024362875da
Signed-off-by: [email protected]
@perheld perheld force-pushed the upstream/ph-vela.ini-config branch from 7c34c38 to 78c4c73 Compare June 25, 2025 05:37
@zingo zingo merged commit 3b0f7c8 into pytorch:main Jun 25, 2025
286 of 291 checks passed
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
The vela compiler supports the option to specify a custom vela.ini file.
But none of the scripts in the arm backend handles this option and
forwards it to vela.

Previous to this commit this was always hardcoded to "Arm/vela.ini"

Now this can be specified with --config that is being forwarded to vela
for the following scripts:
  * examples/arm/run.sh
  * examples/arm/aot_arm_compiler.py

While keeping the default of "Arm/vela.ini" in test/common to not break
CI.

Signed-off-by: [email protected]
@perheld perheld deleted the upstream/ph-vela.ini-config branch September 2, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants