Skip to content

Conversation

@YufengShi-dudu
Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu commented Jun 25, 2025

  • The current aten.mul.Tensor node visitor only supports INT8 data type with BI/INT profile. This patch adds int32 support to the mul node visitor with BI/INT profile.
  • However, tests with int32 inputs that require broadcasting fail on u55 and u85.

Change-Id: I94d9be3be9bbc0935e71156e7dd5e7c1a4029a8c

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- The current aten.mul.Tensor node visitor only supports INT8 data type
  with BI/INT profile. This patch adds int32 support to the mul node
  visitor with BI/INT profile.
- However, tests with int32 inputs that require broadcasting fail on
  u55 and u85.

Change-Id: I94d9be3be9bbc0935e71156e7dd5e7c1a4029a8c
Signed-off-by: Yufeng Shi <[email protected]>
@YufengShi-dudu YufengShi-dudu added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Jun 25, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11964

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit f705749 with merge base 3666680 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2025
@zingo zingo added the release notes: arm Changes to the ARM backend delegate label Jun 25, 2025
@zingo zingo merged commit 15a3db3 into pytorch:main Jun 25, 2025
193 of 195 checks passed
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
…pytorch#11964)

- The current aten.mul.Tensor node visitor only supports INT8 data type
with BI/INT profile. This patch adds int32 support to the mul node
visitor with BI/INT profile.
- However, tests with int32 inputs that require broadcasting fail on u55
and u85.

Signed-off-by: Yufeng Shi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants