[llm] Support different shape of input_pos #11966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request resolved: #11861 Refactoring `op_arange.cpp` to expose `compute_arange_out_size` and `arange_out_impl` for LLM runner to use. See next PR on how to use them. ghstack-source-id: 292529866 @exported-using-ghexport Differential Revision: [D77184741](https://our.internmc.facebook.com/intern/diff/D77184741/)
Pull Request resolved: #11869 For huggingface models, `forward()` is taking `tokens` as well as `cache_positions`, which is a list of cache indices. This is different than the .pte files `export_llama` gives, which are taking `tokens` and `input_pos` where `input_pos` is a scalar tensor. This PR adds support inside `text_decoder_runner.cpp` to handle both shapes of `input_pos`/`cache_positions`. To make the logic more generic without relying on extra metadata, here I'm adding the logic of inspecting method meta and input tensor info, to make a decision if we want to feed in `input_pos` or `cache_position`. ghstack-source-id: 292560636 @exported-using-ghexport Differential Revision: [D77203700](https://our.internmc.facebook.com/intern/diff/D77203700/)
pytorchbot
requested review from
jackzhxng,
kirklandsign,
larryliu0820,
lucylq,
manuelcandales,
mergennachin and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11966
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 5 PendingAs of commit a033c63 with merge base 8b3b028 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jackzhxng
approved these changes
Jun 25, 2025
larryliu0820
added
the
release notes: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11869 by @larryliu0820
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/larryliu0820/67/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/67/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/larryliu0820/66/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/67/orig
@diff-train-skip-merge