Skip to content

Conversation

@metascroy
Copy link
Contributor

This PR is intended to address #11542. A mutable buffer is tagged for consumption by the delegate, but the graph_signature.output_spec keeps the mutable buffer there because it is not in the state_dict (persistent=false), but instead inside of constants.

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11990

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Cancelled Job

As of commit d9c361d with merge base 32d2dfa (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2025
@metascroy metascroy requested a review from angelayi June 26, 2025 02:25
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JacobSzwejbka
Copy link
Contributor

@SS-JIA Is this the issue you were asking me about today?

@metascroy
Copy link
Contributor Author

@angelayi can you take a look before I merge?

@metascroy
Copy link
Contributor Author

@angelayi can you take a look before I merge?

I'll merge now to make the branch cut since @JacobSzwejbka approved, but have a look when you get a chance.

@metascroy metascroy merged commit 7adffe6 into main Jun 26, 2025
95 of 96 checks passed
@metascroy metascroy deleted the fix-mutable-buffer branch June 26, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants