Skip to content

insert write back now tries to avoid inserting if all operations were inplace #12008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Jun 27, 2025
Merged

insert write back now tries to avoid inserting if all operations were inplace #12008

facebook-github-bot merged 1 commit into from
Jun 27, 2025

Conversation

@JacobSzwejbka
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka commented Jun 26, 2025

Summary: Before only considered if the placeholder was the output. Now allow if all operations are inplace.

Differential Revision: D77204116

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12008

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit ff98005 with merge base e9e5255 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77204116

@github-actions
Copy link

github-actions bot commented Jun 26, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jun 26, 2025
@JacobSzwejbka @facebook-github-bot
insert write back now tries to avoid inserting if all operations were…
2a71e1f 
… inplace (pytorch#12008)

Summary:

Before only considered if the placeholder was the output. Now allow if all operations are inplace.

Differential Revision: D77204116
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77204116

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jun 26, 2025
@JacobSzwejbka @facebook-github-bot
insert write back now tries to avoid inserting if all operations were…
69f5bf4 
… inplace (pytorch#12008)

Summary:

Before only considered if the placeholder was the output. Now allow if all operations are inplace.

Differential Revision: D77204116
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77204116

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jun 26, 2025
@JacobSzwejbka @facebook-github-bot
insert write back now tries to avoid inserting if all operations were…
c1b32f9 
… inplace (pytorch#12008)

Summary:

Before only considered if the placeholder was the output. Now allow if all operations are inplace.

Reviewed By: angelayi

Differential Revision: D77204116
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77204116

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jun 26, 2025
@JacobSzwejbka @facebook-github-bot
insert write back now tries to avoid inserting if all operations were…
c87db06 
… inplace (pytorch#12008)

Summary:

Before only considered if the placeholder was the output. Now allow if all operations are inplace.

Reviewed By: angelayi

Differential Revision: D77204116
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jun 26, 2025
@JacobSzwejbka @facebook-github-bot
insert write back now tries to avoid inserting if all operations were…
db8bec5 
… inplace (pytorch#12008)

Summary:

Before only considered if the placeholder was the output. Now allow if all operations are inplace.

Reviewed By: angelayi

Differential Revision: D77204116
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77204116

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77204116

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jun 26, 2025
@JacobSzwejbka @facebook-github-bot
insert write back now tries to avoid inserting if all operations were…
ddc5d9b 
… inplace (pytorch#12008)

Summary:
Pull Request resolved: pytorch#12008

Before only considered if the placeholder was the output. Now allow if all operations are inplace.

Reviewed By: angelayi

Differential Revision: D77204116
@JacobSzwejbka @facebook-github-bot
insert write back now tries to avoid inserting if all operations were…
ff98005 
… inplace (pytorch#12008)

Summary:

Before only considered if the placeholder was the output. Now allow if all operations are inplace.

bypass-github-export-checks
bypass-pytorch-export-checks

Reviewed By: angelayi

Differential Revision: D77204116
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 26, 2025

This pull request was exported from Phabricator. Differential Revision: D77204116

@facebook-github-bot facebook-github-bot merged commit ad73cbd into pytorch:main Jun 27, 2025
96 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelayi angelayi angelayi approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JacobSzwejbka @facebook-github-bot @angelayi