Introduce sym_max and sym_min ops to executorch #12037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimishpatel
requested review from
JacobSzwejbka,
larryliu0820,
manuelcandales and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12037
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1fb27d7 with merge base d72e522 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kimishpatel
added
the
release notes: exir
kimishpatel
force-pushed
the
sym_max_fix
branch
2 times, most recently
from
f167a3a to
b94e801
Compare
JacobSzwejbka
requested changes
Jul 1, 2025
| if (a.isInt() && b.isInt()) { | ||
| out = EValue(std::max(a.toInt(), b.toInt())); | ||
| } else { | ||
| ET_CHECK_MSG(false, "sym_max only supports int inputs, got %zu, %zu", (size_t)a.tag, (size_t)b.tag); |
Contributor
There was a problem hiding this comment.
@Conarnar has a PR up to change all of these checks in prim ops to non fatal
| if (a.isInt() && b.isInt()) { | ||
| out = EValue(std::max(a.toInt(), b.toInt())); | ||
| } else { | ||
| ET_CHECK_MSG( |
Contributor
There was a problem hiding this comment.
Please use ET_KERNEL_CHECK_MSG instead so that we dont abort the process unecessarily
kimishpatel
force-pushed
the
sym_max_fix
branch
2 times, most recently
from
1a4d004 to
d445a0c
Compare
Added corresponding tests as well
JacobSzwejbka
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added corresponding tests as well
Fixes #11988
Test plan
test added