Add gtest macros and matchers for Result<T> and Error. #12038

hsharma35 · 2025-06-26T23:38:02Z

Summary: Adds matcher support for Result and Error types, similar to absl::Status.

Differential Revision: D77409312

pytorch-bot · 2025-06-26T23:38:05Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12038

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit ebbe105 with merge base f673a4b ():

NEW FAILURES - The following jobs have failed:

pull / android / run-emulator (gh)
The process '/usr/bin/sh' failed with exit code 255
pull / unittest / linux / linux-job (gh)
backends/xnnpack/test/ops/test_gelu.py::TestGelu::test_fp16_gelu
pull / unittest / macos / macos-job (gh)
backends/xnnpack/test/ops/test_conv1d.py::TestConv1d::test_qs8_conv1d_batchnorm_seq

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-06-26T23:38:13Z

This pull request was exported from Phabricator. Differential Revision: D77409312

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312

facebook-github-bot · 2025-06-27T20:06:48Z

This pull request was exported from Phabricator. Differential Revision: D77409312

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312

facebook-github-bot · 2025-06-27T22:17:21Z

This pull request was exported from Phabricator. Differential Revision: D77409312

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312

facebook-github-bot · 2025-06-27T22:20:07Z

This pull request was exported from Phabricator. Differential Revision: D77409312

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312

facebook-github-bot · 2025-06-28T18:31:09Z

This pull request was exported from Phabricator. Differential Revision: D77409312

Summary: Pull Request resolved: pytorch#12038 Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312

facebook-github-bot · 2025-06-30T18:09:37Z

This pull request was exported from Phabricator. Differential Revision: D77409312

Summary: Pull Request resolved: pytorch#12038 Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312

larryliu0820 · 2025-06-30T18:38:45Z

runtime/core/testing_util/error_matchers.h

+namespace internal {
+namespace {
+
+constexpr const char* toString(const Error error) {


Can you put this in Error? Would be easier for future changes to Error also change this API.

Also this can be templatized

runtime/core/testing_util/test/error_matchers_test.cpp

larryliu0820

Can you add a test for real code (not error_matchers_test.cpp) that uses these matchers?

runtime/core/testing_util/test/targets.bzl

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Reviewed By: larryliu0820 Differential Revision: D77409312

facebook-github-bot · 2025-06-30T19:43:27Z

This pull request was exported from Phabricator. Differential Revision: D77409312

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Reviewed By: larryliu0820 Differential Revision: D77409312

facebook-github-bot · 2025-06-30T19:56:07Z

This pull request was exported from Phabricator. Differential Revision: D77409312

Summary: Pull Request resolved: pytorch#12038 Adds matcher support for Result and Error types, similar to absl::Status. Reviewed By: larryliu0820 Differential Revision: D77409312

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Reviewed By: larryliu0820 Differential Revision: D77409312

Summary: Pull Request resolved: pytorch#12038 Adds matcher support for Result and Error types, similar to absl::Status. Reviewed By: larryliu0820 Differential Revision: D77409312

facebook-github-bot · 2025-06-30T22:01:09Z

This pull request was exported from Phabricator. Differential Revision: D77409312

Differential Revision: D77409312 Pull Request resolved: pytorch#12038

hsharma35 requested review from JacobSzwejbka, lucylq and swolchok as code owners June 26, 2025 23:38

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2025

facebook-github-bot added the fb-exported label Jun 26, 2025

mergennachin requested a review from larryliu0820 June 27, 2025 14:27

hsharma35 force-pushed the export-D77409312 branch from 144422b to 225ab71 Compare June 27, 2025 20:06

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jun 27, 2025

Add gtest macros and matchers for Result<T> and Error. (pytorch#12038)

225ab71

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jun 27, 2025

Add gtest macros and matchers for Result<T> and Error. (pytorch#12038)

9ee10b8

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312

hsharma35 added the release notes: none Do not include this in the release notes label Jun 27, 2025

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jun 27, 2025

Add gtest macros and matchers for Result<T> and Error. (pytorch#12038)

7151468

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312

hsharma35 force-pushed the export-D77409312 branch from 225ab71 to 7151468 Compare June 27, 2025 22:17

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jun 27, 2025

Add gtest macros and matchers for Result<T> and Error. (pytorch#12038)

bcb62f6

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312

hsharma35 force-pushed the export-D77409312 branch from 7151468 to bcb62f6 Compare June 27, 2025 22:19

hsharma35 requested a review from kimishpatel June 27, 2025 22:25

hsharma35 force-pushed the export-D77409312 branch from bcb62f6 to 7f45bf0 Compare June 28, 2025 18:26

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jun 28, 2025

Add gtest macros and matchers for Result<T> and Error. (pytorch#12038)

7f45bf0

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312

hsharma35 force-pushed the export-D77409312 branch from 7f45bf0 to a2a7476 Compare June 28, 2025 18:31

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Jun 30, 2025

Add gtest macros and matchers for Result<T> and Error. (pytorch#12038)

3ee5d59

Summary: Adds matcher support for Result and Error types, similar to absl::Status. Differential Revision: D77409312

hsharma35 force-pushed the export-D77409312 branch from a2a7476 to 3ee5d59 Compare June 30, 2025 18:05

hsharma35 force-pushed the export-D77409312 branch from 3ee5d59 to e962c21 Compare June 30, 2025 18:09

larryliu0820 reviewed Jun 30, 2025

View reviewed changes

runtime/core/testing_util/test/error_matchers_test.cpp Show resolved Hide resolved

larryliu0820 approved these changes Jun 30, 2025

View reviewed changes

runtime/core/testing_util/test/targets.bzl Outdated Show resolved Hide resolved

hsharma35 force-pushed the export-D77409312 branch from e962c21 to dfd68f5 Compare June 30, 2025 19:43

hsharma35 force-pushed the export-D77409312 branch from dfd68f5 to 87dd7a5 Compare June 30, 2025 19:51

hsharma35 force-pushed the export-D77409312 branch from 87dd7a5 to 11a8344 Compare June 30, 2025 19:56

hsharma35 force-pushed the export-D77409312 branch from 11a8344 to 7717eb7 Compare June 30, 2025 21:57

Add gtest macros and matchers for Result<T> and Error. (pytorch#12038)

ebbe105

Summary: Pull Request resolved: pytorch#12038 Adds matcher support for Result and Error types, similar to absl::Status. Reviewed By: larryliu0820 Differential Revision: D77409312

hsharma35 force-pushed the export-D77409312 branch from 7717eb7 to ebbe105 Compare June 30, 2025 22:01

facebook-github-bot merged commit 75e4044 into pytorch:main Jul 1, 2025
93 of 98 checks passed

Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025

Add gtest macros and matchers for Result<T> and Error.

e70d0b1

Differential Revision: D77409312 Pull Request resolved: pytorch#12038

Add gtest macros and matchers for Result<T> and Error. #12038

Add gtest macros and matchers for Result<T> and Error. #12038

Uh oh!

Conversation

hsharma35 commented Jun 26, 2025

Uh oh!

pytorch-bot bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12038

❌ 3 New Failures

Uh oh!

facebook-github-bot commented Jun 26, 2025

Uh oh!

facebook-github-bot commented Jun 27, 2025

Uh oh!

facebook-github-bot commented Jun 27, 2025

Uh oh!

facebook-github-bot commented Jun 27, 2025

Uh oh!

facebook-github-bot commented Jun 28, 2025

Uh oh!

facebook-github-bot commented Jun 30, 2025

Uh oh!

larryliu0820 Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

larryliu0820 Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

larryliu0820 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

facebook-github-bot commented Jun 30, 2025

Uh oh!

facebook-github-bot commented Jun 30, 2025

Uh oh!

facebook-github-bot commented Jun 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pytorch-bot bot commented Jun 26, 2025 •

edited

Loading