Skip to content

Remove unnecessary validation for local global attention #12049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackzhxng merged 1 commit into from
Jun 27, 2025
+0 −14
Merged

Remove unnecessary validation for local global attention #12049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions extension/llm/export/config/llm_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"""

import argparse
import ast
import re
from dataclasses import dataclass, field
from enum import Enum
Expand Down Expand Up @@ -166,7 +165,6 @@ class ModelConfig:

def __post_init__(self):
self._validate_attention_sink()
self._validate_local_global_attention()

if self.quantize_kv_cache and not self.use_kv_cache:
raise ValueError(
Expand All @@ -186,18 +184,6 @@ def _validate_attention_sink(self):
"The value of use_attention_sink must be structured like '<sink_size>,<window_size>,<batch_eviction_size>'"
)

def _validate_local_global_attention(self):
if self.local_global_attention:
local_global_err = "The value of local_global_attention must be a list of integers, e.g., [0, 16, 0, 16]"
try:
parsed = ast.literal_eval(self.local_global_attention)
if not (
isinstance(parsed, list) and all(isinstance(i, int) for i in parsed)
):
raise ValueError(local_global_err)
except Exception:
raise ValueError(local_global_err)


################################################################################
################################ ExportConfig ##################################
Expand Down
Loading