Skip to content

USe -WShadow in clang builds #12052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
GregoryComer wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

USe -WShadow in clang builds #12052

GregoryComer wants to merge 1 commit into from
+7 −0

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jun 27, 2025

Summary

Enable -Wshadow and -Werror=shadow for Clang builds. This is due to needing to revert or forward fix several commits when Meta-internal builds fail due to enforcing this. The option is enabled only on Clang as GCC's version is stricter (mainly around constructor parameters with the same name as class fields), which requires larger changes that I don't personally feel are necessary. Enforcing Clang's version in CI will be sufficient to prevent further reverts / issues as a result of shadowing.

Test plan

CI

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12052

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 62 New Failures

As of commit a4754da with merge base a2b620a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2025
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Jun 27, 2025
@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Sep 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 2, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 will be requested when the pull request is marked ready for review larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign will be requested when the pull request is marked ready for review kirklandsign is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes stale PRs inactive for over 60 days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GregoryComer @facebook-github-bot