Skip to content

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Jun 27, 2025

Currently hydra and omegaconf are set as dependency during development only.

But it should just be part of the core dependencies now (it is being used in extensions/llm/export_llm.py) for the pip package.

Test Plan:

pip freeze | grep hydra (no result)
pip install -e . --no-build-isolation
pip freeze | grep hydra (found hydra)

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12060

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit ee67473 with merge base 8b3b028 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2025
@mergennachin mergennachin requested review from jackzhxng and jathu June 27, 2025 15:44
@mergennachin mergennachin added release notes: none Do not include this in the release notes ciflow/trunk labels Jun 27, 2025
@mergennachin mergennachin added this to the 0.7.0 milestone Jun 27, 2025
@mergennachin mergennachin merged commit ab4217e into main Jun 27, 2025
200 of 201 checks passed
@mergennachin mergennachin deleted the test_hydra branch June 27, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants