Add export recipes for xnnpack (#12069) #12070

abhinaykukkadapu · 2025-06-27T20:13:31Z

Summary: Enables basic export recipes for XNNPack backend described in #12069

Differential Revision: D77414795

pytorch-bot · 2025-06-27T20:13:34Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12070

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit 0827d84 with merge base 042eb1a ():

NEW FAILURE - The following job has failed:

pull / test-eval_llama-mmlu-linux / linux-job (gh)
RuntimeError: Command docker exec -t 4bfe0bafbee6d5284ccacf0ac1819263ecd669cedd2369b433a5d785b22978ba /exec failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-06-27T20:13:40Z

This pull request was exported from Phabricator. Differential Revision: D77414795

github-actions · 2025-06-27T20:14:11Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary: Enables basic export recipes for XNNPack backend described in pytorch#12069 Differential Revision: D77414795

facebook-github-bot · 2025-06-27T20:15:34Z

This pull request was exported from Phabricator. Differential Revision: D77414795

backends/xnnpack/recipes/recipes.py

backends/xnnpack/test/recipes/test_xnnpack_recipes.py

Summary: Enables basic export recipes for XNNPack backend described in pytorch#12069 Adds five recipes: a. static per channel quant b. static per tensor quant c. dynamic per channel quant d. fp32 e. 8a4w Differential Revision: D77414795

facebook-github-bot · 2025-07-02T21:34:17Z

This pull request was exported from Phabricator. Differential Revision: D77414795

Summary: Enables basic export recipes for XNNPack backend described in pytorch#12069 Adds five recipes: a. static per channel quant b. static per tensor quant c. dynamic per channel quant d. fp32 e. 8a4w Differential Revision: D77414795

facebook-github-bot · 2025-07-02T22:50:43Z

This pull request was exported from Phabricator. Differential Revision: D77414795

Summary: Enables basic export recipes for XNNPack backend described in pytorch#12069 Adds five recipes: a. static per channel quant b. static per tensor quant c. dynamic per channel quant d. fp32 e. 8a4w Differential Revision: D77414795

facebook-github-bot · 2025-07-02T23:05:33Z

This pull request was exported from Phabricator. Differential Revision: D77414795

facebook-github-bot · 2025-07-02T23:06:59Z

This pull request was exported from Phabricator. Differential Revision: D77414795

Summary: Pull Request resolved: pytorch#12070 Enables basic export recipes for XNNPack backend described in pytorch#12069 Adds five recipes: a. static per channel quant b. static per tensor quant c. dynamic per channel quant d. fp32 e. 8a4w Differential Revision: D77414795

Summary: Pull Request resolved: pytorch#12070 Enables basic export recipes for XNNPack backend described in pytorch#12069 Added recipes: 1. int8 da per channel 2. int8 da per tensor 3. int8 static per channel 4. int8 static per tensor 5. int8da4w dynamic per channel 6. int8da4w dynamic per tensor Reviewed By: metascroy, kimishpatel Differential Revision: D77414795

Summary: Enables basic export recipes for XNNPack backend described in pytorch#12069 Pull Request resolved: pytorch#12070 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: metascroy, kimishpatel Differential Revision: D77414795 Pulled By: abhinaykukkadapu

facebook-github-bot · 2025-07-14T18:35:49Z

@abhinaykukkadapu has imported this pull request. If you are a Meta employee, you can view this in D77414795.

facebook-github-bot · 2025-07-14T22:05:38Z

This pull request was exported from Phabricator. Differential Revision: D77414795

Summary: Enables basic export recipes for XNNPack backend described in pytorch#12069 Pull Request resolved: pytorch#12070 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: metascroy, kimishpatel Differential Revision: D77414795 Pulled By: abhinaykukkadapu

facebook-github-bot · 2025-07-14T22:16:13Z

This pull request was exported from Phabricator. Differential Revision: D77414795

Summary: Enables basic export recipes for XNNPack backend described in pytorch#12069 Pull Request resolved: pytorch#12070 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: metascroy, mcr229, kimishpatel Differential Revision: D77414795 Pulled By: abhinaykukkadapu

facebook-github-bot · 2025-07-14T23:43:31Z

This pull request was exported from Phabricator. Differential Revision: D77414795

Summary: Enables basic export recipes for XNNPack backend described in pytorch#12069 Pull Request resolved: pytorch#12070 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: metascroy, mcr229, kimishpatel Differential Revision: D77414795 Pulled By: abhinaykukkadapu

facebook-github-bot · 2025-07-14T23:52:56Z

This pull request was exported from Phabricator. Differential Revision: D77414795

Summary: Enables basic export recipes for XNNPack backend described in pytorch#12069 Pull Request resolved: pytorch#12070 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: metascroy, mcr229, kimishpatel Differential Revision: D77414795 Pulled By: abhinaykukkadapu

facebook-github-bot · 2025-07-14T23:57:31Z

This pull request was exported from Phabricator. Differential Revision: D77414795

Summary: Enables basic export recipes for XNNPack backend described in pytorch#12069 Pull Request resolved: pytorch#12070 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: metascroy, mcr229, kimishpatel Differential Revision: D77414795 Pulled By: abhinaykukkadapu

facebook-github-bot · 2025-07-15T04:41:45Z

@abhinaykukkadapu has imported this pull request. If you are a Meta employee, you can view this in D77414795.

digantdesai

Sorry a bit late, forgot to submit earlier

digantdesai · 2025-07-14T10:18:07Z

backends/xnnpack/recipes/xnnpack_recipe_provider.py

+class XNNPACKRecipeProvider(BackendRecipeProvider):
+    @property
+    def backend_name(self) -> str:
+        return "xnnpack"


we might already have this somewhere. Just want to make sure we are consistent.

digantdesai · 2025-07-14T10:19:31Z

backends/xnnpack/recipes/xnnpack_recipe_provider.py

+        return list(XNNPackRecipeType)
+
+    def create_recipe(
+        self, recipe_type: RecipeType, **kwargs: Any


Do we have to use kwargs? It makes it hard to read and easier to slip on typing checks or other validations.

digantdesai · 2025-07-14T10:21:27Z

backends/xnnpack/recipes/xnnpack_recipe_provider.py

+        if recipe_type == XNNPackRecipeType.FP32:
+            return self._build_fp32_recipe(recipe_type)
+
+        elif recipe_type == XNNPackRecipeType.INT8_DYNAMIC_PER_CHANNEL:


nit using a match stmt might be cleaner?

digantdesai · 2025-07-14T10:23:22Z

backends/xnnpack/recipes/xnnpack_recipe_provider.py

+        )
+
+        quant_recipe = QuantizationRecipe(
+            quantizers=None,


why is this none?

digantdesai · 2025-07-14T10:25:16Z

backends/xnnpack/test/recipes/test_xnnpack_recipes.py

+        )
+
+    def test_all_models_with_recipes(self) -> None:
+        models_to_test = [


abhinaykukkadapu requested review from digantdesai and mcr229 as code owners June 27, 2025 20:13

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2025

facebook-github-bot added the fb-exported label Jun 27, 2025

abhinaykukkadapu force-pushed the export-D77414795 branch from b46b07e to ce2010d Compare June 27, 2025 20:15

mcr229 suggested changes Jun 30, 2025

View reviewed changes

backends/xnnpack/recipes/recipes.py Outdated Show resolved Hide resolved

backends/xnnpack/recipes/recipes.py Outdated Show resolved Hide resolved

backends/xnnpack/test/recipes/test_xnnpack_recipes.py Show resolved Hide resolved

abhinaykukkadapu self-assigned this Jul 1, 2025

abhinaykukkadapu added this to ExecuTorch Core Jul 1, 2025

abhinaykukkadapu moved this to In progress in ExecuTorch Core Jul 1, 2025

abhinaykukkadapu force-pushed the export-D77414795 branch from ce2010d to e053611 Compare July 2, 2025 21:34

abhinaykukkadapu force-pushed the export-D77414795 branch from e053611 to 6e1f918 Compare July 2, 2025 22:50

abhinaykukkadapu force-pushed the export-D77414795 branch from 6e1f918 to ee59d57 Compare July 2, 2025 23:01

abhinaykukkadapu force-pushed the export-D77414795 branch from ee59d57 to e2549fc Compare July 2, 2025 23:05

abhinaykukkadapu force-pushed the export-D77414795 branch from e2549fc to 3290db4 Compare July 2, 2025 23:07

abhinaykukkadapu force-pushed the export-D77414795 branch from 3290db4 to 913b42d Compare July 12, 2025 01:09

abhinaykukkadapu force-pushed the export-D77414795 branch from e812b10 to 6c2af2a Compare July 14, 2025 05:28

abhinaykukkadapu force-pushed the export-D77414795 branch from 6c2af2a to bb68de8 Compare July 14, 2025 18:32

metascroy approved these changes Jul 14, 2025

View reviewed changes

abhinaykukkadapu removed this from ExecuTorch Core Jul 14, 2025

abhinaykukkadapu force-pushed the export-D77414795 branch from bb68de8 to 42691df Compare July 14, 2025 22:05

abhinaykukkadapu requested a review from mcr229 July 14, 2025 22:06

mcr229 approved these changes Jul 14, 2025

View reviewed changes

abhinaykukkadapu force-pushed the export-D77414795 branch from 42691df to ef5d66e Compare July 14, 2025 22:16

abhinaykukkadapu force-pushed the export-D77414795 branch from ef5d66e to cd09f96 Compare July 14, 2025 23:43

abhinaykukkadapu force-pushed the export-D77414795 branch from cd09f96 to b4ad4fa Compare July 14, 2025 23:53

abhinaykukkadapu force-pushed the export-D77414795 branch from b4ad4fa to df0cb02 Compare July 14, 2025 23:57

abhinaykukkadapu force-pushed the export-D77414795 branch from df0cb02 to 3b6a308 Compare July 15, 2025 02:46

abhinaykukkadapu force-pushed the export-D77414795 branch from 3b6a308 to 0827d84 Compare July 15, 2025 03:42

abhinaykukkadapu merged commit a711af7 into pytorch:main Jul 15, 2025
104 of 106 checks passed

digantdesai reviewed Jul 21, 2025

View reviewed changes

Add export recipes for xnnpack (#12069) #12070

Add export recipes for xnnpack (#12069) #12070

Uh oh!

Conversation

abhinaykukkadapu commented Jun 27, 2025

Uh oh!

pytorch-bot bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12070

❌ 1 New Failure, 1 Pending

Uh oh!

facebook-github-bot commented Jun 27, 2025

Uh oh!

github-actions bot commented Jun 27, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented Jul 2, 2025

Uh oh!

facebook-github-bot commented Jul 2, 2025

Uh oh!

facebook-github-bot commented Jul 2, 2025

Uh oh!

facebook-github-bot commented Jul 2, 2025

Uh oh!

facebook-github-bot commented Jul 14, 2025

Uh oh!

facebook-github-bot commented Jul 14, 2025

Uh oh!

facebook-github-bot commented Jul 14, 2025

Uh oh!

facebook-github-bot commented Jul 14, 2025

Uh oh!

facebook-github-bot commented Jul 14, 2025

Uh oh!

facebook-github-bot commented Jul 14, 2025

Uh oh!

facebook-github-bot commented Jul 15, 2025

Uh oh!

Uh oh!

digantdesai left a comment

Choose a reason for hiding this comment

Uh oh!

digantdesai Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

digantdesai Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

digantdesai Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

digantdesai Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

digantdesai Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pytorch-bot bot commented Jun 27, 2025 •

edited

Loading

This PR needs a `release notes:` label