-
Couldn't load subscription status.
- Fork 700
Update test_ring_attention.py to fix CI #12074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12074
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 79f6909 with merge base cc3a35f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
The said tests are passing internally but fail in OSS CI likely due to tolerance being 1e-7. But these failures are flaky so they dont always fail. Skipping to fix CI
372601e to
cba000e
Compare
|
This is not flaky per se. It is failing consistently in OSS https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=unittest |
|
I'd rather revert this PR #12090 instead |
|
It is strange then we landed the PR if it broke the test. However, I think it is completely accidental. Let me see if I can repro this. Last time I tried, which likely was before that PR, I could not repro it |
Ok thast fine with me too, but a) I dont think they are related and b) I did see this being flaky but lets wait for flakiness to show up again before disabling it. |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
The said tests are passing internally but fail in OSS CI likely due to tolerance being 1e-7. But these failures are flaky so they dont always fail. Skipping to fix CI
Summary
[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.
[PLEASE REMOVE] If this PR closes an issue, please add a
Fixes #<issue-id>line.[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.
Test plan
[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.