Skip to content

Conversation

@kimishpatel
Copy link
Contributor

The said tests are passing internally but fail in OSS CI likely due to tolerance being 1e-7. But these failures are flaky so they dont always fail. Skipping to fix CI

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12074

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 79f6909 with merge base cc3a35f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2025
@kimishpatel kimishpatel requested a review from GregoryComer June 27, 2025 21:49
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

The said tests are passing internally but fail in OSS CI likely due to tolerance being 1e-7. But these failures are flaky so they dont always fail. Skipping to fix CI
@kimishpatel kimishpatel force-pushed the kimishpatel-patch-1 branch from 372601e to cba000e Compare June 28, 2025 02:39
@mergennachin
Copy link
Contributor

@kimishpatel

This is not flaky per se. It is failing consistently in OSS https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=unittest

After @leafs1 's PR in #11286

@mergennachin
Copy link
Contributor

I'd rather revert this PR #12090 instead

@kimishpatel
Copy link
Contributor Author

It is strange then we landed the PR if it broke the test.

However, I think it is completely accidental. Let me see if I can repro this. Last time I tried, which likely was before that PR, I could not repro it

@kimishpatel
Copy link
Contributor Author

I'd rather revert this PR #12090 instead

Ok thast fine with me too, but a) I dont think they are related and b) I did see this being flaky but lets wait for flakiness to show up again before disabling it.

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. stale PRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants