Skip to content

unbreak lintrunner in backends/arm #12075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2025
Merged

unbreak lintrunner in backends/arm #12075

merged 1 commit into from
Jun 28, 2025

Conversation

@swolchok
Copy link
Contributor

I mistakenly thought lint issues on #12068 were inaccurate. Fast following with fix.

@swolchok
Update
5055a28 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jun 27, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12075

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 2 Pending, 2 Unrelated Failures

As of commit 5055a28 with merge base 2a2d757 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jun 27, 2025
@swolchok
unbreak lintrunner in backends/arm
cc2c16d 
I mistakenly thought lint issues on #12068 were inaccurate. Fast following with fix.


ghstack-source-id: bad7fa8
ghstack-comment-id: 3014481657
Pull-Request-resolved: #12075
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2025
@swolchok swolchok added the release notes: none Do not include this in the release notes label Jun 27, 2025
@swolchok swolchok merged commit cc3a35f into main Jun 28, 2025
95 of 98 checks passed
@swolchok swolchok deleted the gh/swolchok/483/head branch June 28, 2025 02:49
@digantdesai
Copy link
Contributor

Thanks Scott.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregoryComer GregoryComer GregoryComer approved these changes

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel is a code owner

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swolchok @digantdesai @GregoryComer @facebook-github-bot