Add MergedDataMap to method #12088

lucylq · 2025-06-28T00:03:51Z

Stack from ghstack (oldest at bottom):

Differential Revision: D77472917

Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/) [ghstack-poisoned]

Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/) ghstack-source-id: 293198308 Pull Request resolved: #12088

pytorch-bot · 2025-06-28T00:03:55Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12088

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 6e9429a with merge base ba19c75 ():

NEW FAILURE - The following job has failed:

Build documentation / build (buck2) / Build doc (gh)
RuntimeError: Command docker exec -t 65184f5e9ff336d1caa17536441225985a97a7caa15e1a7012f1b4aef63b15de /exec failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / test-models-linux (mobilebert, portable, linux.2xlarge) / linux-job (gh) (trunk failure)
##[error]The operation was canceled.
pull / test-models-linux (mobilebert, xnnpack-quantization-delegation, linux.2xlarge) / linux-job (gh) (trunk failure)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-06-28T00:04:14Z

This pull request was exported from Phabricator. Differential Revision: D77472917

github-actions · 2025-06-28T00:04:55Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/) [ghstack-poisoned]

Pull Request resolved: #12088 ghstack-source-id: 293198308 Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/)

facebook-github-bot · 2025-07-02T22:49:45Z

This pull request was exported from Phabricator. Differential Revision: D77472917

Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/) [ghstack-poisoned]

Pull Request resolved: #12088 ghstack-source-id: 293198308 Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/)

facebook-github-bot · 2025-07-03T00:05:33Z

This pull request was exported from Phabricator. Differential Revision: D77472917

Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/) [ghstack-poisoned]

Pull Request resolved: #12088 ghstack-source-id: 294883360 Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/)

facebook-github-bot · 2025-07-08T16:25:56Z

This pull request was exported from Phabricator. Differential Revision: D77472917

Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/) [ghstack-poisoned]

Pull Request resolved: #12088 ghstack-source-id: 294943572 Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/)

facebook-github-bot · 2025-07-08T20:17:35Z

This pull request was exported from Phabricator. Differential Revision: D77472917

JacobSzwejbka · 2025-07-09T16:45:55Z

runtime/executor/method.cpp

 }

-Error Method::parse_values(const NamedDataMap* named_data_map) {
+Error Method::parse_values(const NamedDataMap* external_data_map) {


I feel like named was the better name since it possibly contains data embedded in the pte

oops, didn't see this. This data map comes from the PTD file (external), so it shouldn't contain items from the PTE --> that's the pte_data_map

JacobSzwejbka · 2025-07-09T16:47:22Z

runtime/executor/method.cpp

  for (const auto i : c10::irange(n_external_constants_)) {
    external_constants_[i].buffer.~FreeableBuffer();
  }
+  // Free the MergedDataMap.


I guess this is fine. It doesnt do anything though. The MergedMap is trivially destructable

@lucylq

This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #12088 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/88/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/88/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/87/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/88/orig @diff-train-skip-merge --------- Co-authored-by: lucylq <[email protected]>

Add MergedDataMap to method

19c16cb

Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/) [ghstack-poisoned]

lucylq requested review from JacobSzwejbka and swolchok as code owners June 28, 2025 00:03

lucylq mentioned this pull request Jun 28, 2025

Introduce MergedDataMap #12087

Merged

lucylq added a commit that referenced this pull request Jun 28, 2025

Add MergedDataMap to method

8d0f624

Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/) ghstack-source-id: 293198308 Pull Request resolved: #12088

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 28, 2025

facebook-github-bot added the fb-exported label Jun 28, 2025

lucylq changed the title ~~Add MergedDataMap to method~~ [wip] Add MergedDataMap to method Jun 28, 2025

Update on "[wip] Add MergedDataMap to method"

a37a615

Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/) [ghstack-poisoned]

lucylq added a commit that referenced this pull request Jul 2, 2025

Add MergedDataMap to method

62ae682

Pull Request resolved: #12088 ghstack-source-id: 293198308 Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/)

Update on "[wip] Add MergedDataMap to method"

9d83166

Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/) [ghstack-poisoned]

lucylq added a commit that referenced this pull request Jul 2, 2025

Add MergedDataMap to method

c48f6a8

Pull Request resolved: #12088 ghstack-source-id: 293198308 Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/)

lucylq mentioned this pull request Jul 3, 2025

Add merge to NamedDataMap API #10551

Closed

Update on "[wip] Add MergedDataMap to method"

f5da980

Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/) [ghstack-poisoned]

lucylq added a commit that referenced this pull request Jul 8, 2025

Add MergedDataMap to method

709d2d7

Pull Request resolved: #12088 ghstack-source-id: 294883360 Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/)

Update on "[wip] Add MergedDataMap to method"

6e9429a

Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/) [ghstack-poisoned]

lucylq added a commit that referenced this pull request Jul 8, 2025

Add MergedDataMap to method

dbddc8c

Pull Request resolved: #12088 ghstack-source-id: 294943572 Differential Revision: [D77472917](https://our.internmc.facebook.com/intern/diff/D77472917/)

lucylq changed the title ~~[wip] Add MergedDataMap to method~~ Add MergedDataMap to method Jul 8, 2025

JacobSzwejbka reviewed Jul 9, 2025

View reviewed changes

JacobSzwejbka approved these changes Jul 9, 2025

View reviewed changes

facebook-github-bot merged commit 0b4d3d1 into gh/lucylq/88/base Jul 9, 2025
97 of 103 checks passed

facebook-github-bot deleted the gh/lucylq/88/head branch July 9, 2025 17:57

facebook-github-bot temporarily deployed to cherry-pick-bot July 9, 2025 17:57 — with GitHub Actions Inactive

pytorchbot mentioned this pull request Jul 9, 2025

Add MergedDataMap to method #12305

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add MergedDataMap to method #12088

Add MergedDataMap to method #12088

Uh oh!

lucylq commented Jun 28, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jun 28, 2025 •

edited

Loading

Uh oh!

facebook-github-bot commented Jun 28, 2025

Uh oh!

github-actions bot commented Jun 28, 2025

Uh oh!

facebook-github-bot commented Jul 2, 2025

Uh oh!

facebook-github-bot commented Jul 3, 2025

Uh oh!

facebook-github-bot commented Jul 8, 2025

Uh oh!

facebook-github-bot commented Jul 8, 2025

Uh oh!

JacobSzwejbka Jul 9, 2025

Uh oh!

lucylq Jul 9, 2025

Uh oh!

JacobSzwejbka Jul 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Add MergedDataMap to method #12088

Add MergedDataMap to method #12088

Uh oh!

Conversation

lucylq commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12088

❌ 1 New Failure, 2 Unrelated Failures

Uh oh!

facebook-github-bot commented Jun 28, 2025

Uh oh!

github-actions bot commented Jun 28, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Jul 2, 2025

Uh oh!

facebook-github-bot commented Jul 3, 2025

Uh oh!

facebook-github-bot commented Jul 8, 2025

Uh oh!

facebook-github-bot commented Jul 8, 2025

Uh oh!

JacobSzwejbka Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

lucylq Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

JacobSzwejbka Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lucylq commented Jun 28, 2025 •

edited

Loading

pytorch-bot bot commented Jun 28, 2025 •

edited

Loading

This PR needs a `release notes:` label

JacobSzwejbka Jul 9, 2025 •

edited

Loading