Add required_for_abi_source_only = True to extension/android:executorch_llama
#12093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12093
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit a224583 with merge base f2f2a9d ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77479748 |
Contributor
Author
|
@pytorchbot label "release notes: build" |
pytorch-bot
bot
added
the
release notes: build
xuhdev
added a commit
to xuhdev/executorch
that referenced
this pull request
Jul 2, 2025
…orch_llama (pytorch#12093) Summary: [Buck's document on Java source ABI](https://buck.build/concept/java_abis.html) recommends adding `required_for_source_abi = True` to targets that export annotations: > ... All annotations and compile-time constants (including enum values) used in the interface of a rule must be present during source-only ABI generation. > The error will suggest adding required_for_source_abi = True to any rule that defines an annotation type or a compile-time constant that is used from another rule, ... Differential Revision: D77479748
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77479748 |
digantdesai
approved these changes
Jul 3, 2025
Contributor
|
Rebase and make sure the android emulator job is ok or unrelated. Thanks. |
xuhdev
added a commit
to xuhdev/executorch
that referenced
this pull request
Jul 3, 2025
…orch_llama (pytorch#12093) Summary: [Buck's document on Java source ABI](https://buck.build/concept/java_abis.html) recommends adding `required_for_source_abi = True` to targets that export annotations: > ... All annotations and compile-time constants (including enum values) used in the interface of a rule must be present during source-only ABI generation. > The error will suggest adding required_for_source_abi = True to any rule that defines an annotation type or a compile-time constant that is used from another rule, ... Reviewed By: digantdesai, thezhangwei Differential Revision: D77479748
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77479748 |
xuhdev
added a commit
to xuhdev/executorch
that referenced
this pull request
Jul 3, 2025
…orch_llama (pytorch#12093) Summary: Pull Request resolved: pytorch#12093 [Buck's document on Java source ABI](https://buck.build/concept/java_abis.html) recommends adding `required_for_source_abi = True` to targets that export annotations: > ... All annotations and compile-time constants (including enum values) used in the interface of a rule must be present during source-only ABI generation. > The error will suggest adding required_for_source_abi = True to any rule that defines an annotation type or a compile-time constant that is used from another rule, ... Reviewed By: digantdesai, thezhangwei Differential Revision: D77479748
xuhdev
added a commit
to xuhdev/executorch
that referenced
this pull request
Jul 4, 2025
…orch_llama (pytorch#12093) Summary: [Buck's document on Java source ABI](https://buck.build/concept/java_abis.html) recommends adding `required_for_source_abi = True` to targets that export annotations: > ... All annotations and compile-time constants (including enum values) used in the interface of a rule must be present during source-only ABI generation. > The error will suggest adding required_for_source_abi = True to any rule that defines an annotation type or a compile-time constant that is used from another rule, ... Reviewed By: digantdesai, thezhangwei Differential Revision: D77479748
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77479748 |
xuhdev
added a commit
to xuhdev/executorch
that referenced
this pull request
Jul 4, 2025
…orch_llama (pytorch#12093) Summary: [Buck's document on Java source ABI](https://buck.build/concept/java_abis.html) recommends adding `required_for_source_abi = True` to targets that export annotations: > ... All annotations and compile-time constants (including enum values) used in the interface of a rule must be present during source-only ABI generation. > The error will suggest adding required_for_source_abi = True to any rule that defines an annotation type or a compile-time constant that is used from another rule, ... Reviewed By: digantdesai, thezhangwei Differential Revision: D77479748
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77479748 |
Contributor
Author
|
@digantdesai Could you check whether the emulator failure is relevant? I'm wondering if it is because I made the PR and don't have relevant permissions: |
xuhdev
added a commit
to xuhdev/executorch
that referenced
this pull request
Jul 4, 2025
…orch_llama (pytorch#12093) Summary: [Buck's document on Java source ABI](https://buck.build/concept/java_abis.html) recommends adding `required_for_source_abi = True` to targets that export annotations: > ... All annotations and compile-time constants (including enum values) used in the interface of a rule must be present during source-only ABI generation. > The error will suggest adding required_for_source_abi = True to any rule that defines an annotation type or a compile-time constant that is used from another rule, ... Reviewed By: digantdesai, thezhangwei Differential Revision: D77479748
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77479748 |
…orch_llama (pytorch#12093) Summary: [Buck's document on Java source ABI](https://buck.build/concept/java_abis.html) recommends adding `required_for_source_abi = True` to targets that export annotations: > ... All annotations and compile-time constants (including enum values) used in the interface of a rule must be present during source-only ABI generation. > The error will suggest adding required_for_source_abi = True to any rule that defines an annotation type or a compile-time constant that is used from another rule, ... Reviewed By: digantdesai, thezhangwei Differential Revision: D77479748
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77479748 |
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
…orch_llama Differential Revision: D77479748 Pull Request resolved: pytorch#12093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Buck's document on Java source ABI recommends adding
required_for_source_abi = Trueto targets that export annotations:Differential Revision: D77479748