Skip to content

Conversation

@aaron-ang
Copy link
Contributor

@aaron-ang aaron-ang commented Jul 1, 2025

Summary

Reopening from #11537
Fixes #11370

Test plan

Use existing tests since we are doing a drop-in replacement for overflow checks.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12125

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit e018cd1 with merge base aab8021 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2025
@aaron-ang aaron-ang changed the title import safe_numerics from PyTorch Use safe_numerics util from PyTorch Jul 1, 2025
@aaron-ang
Copy link
Contributor Author

@pytorchbot label "release notes: runtime"

@pytorch-bot pytorch-bot bot added the release notes: runtime Changes related to the core runtime which loads the program methods, initializes delegates, and runs label Jul 1, 2025
@mergennachin mergennachin added the community: contribution PRs coming from community (excluding hardware partners) label Jul 3, 2025
@aaron-ang
Copy link
Contributor Author

aaron-ang commented Jul 4, 2025

hi @JacobSzwejbka, I can't seem to figure out why the import #include <executorch/runtime/core/portable_type/c10/c10/util/safe_numerics.h> is not recognized..

Edit: I've rebased with main and added the file paths to targets.bzl. Hope this fixes the runtime errors.

@aaron-ang aaron-ang force-pushed the safe-numerics branch 2 times, most recently from d084236 to 53a1d26 Compare July 14, 2025 15:01
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good as long as tests pass, just approved them to run

@aaron-ang aaron-ang force-pushed the safe-numerics branch 4 times, most recently from 13f4d46 to c7686a3 Compare July 14, 2025 17:13
@aaron-ang
Copy link
Contributor Author

@swolchok can you try running the CI again?

@swolchok
Copy link
Contributor

CI looks good, can you rebase and fix the conflict?

@aaron-ang
Copy link
Contributor Author

@swolchok rebased

@swolchok
Copy link
Contributor

unittest linux failures look ignorable

@swolchok swolchok merged commit 15442af into pytorch:main Jul 18, 2025
98 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. community: contribution PRs coming from community (excluding hardware partners) release notes: runtime Changes related to the core runtime which loads the program methods, initializes delegates, and runs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import and extend c10/util/safe_numerics.h

4 participants