-
Notifications
You must be signed in to change notification settings - Fork 700
Use safe_numerics util from PyTorch #12125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12125
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit e018cd1 with merge base aab8021 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "release notes: runtime" |
|
hi @JacobSzwejbka, I can't seem to figure out why the import Edit: I've rebased with |
d084236 to
53a1d26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good as long as tests pass, just approved them to run
13f4d46 to
c7686a3
Compare
|
@swolchok can you try running the CI again? |
|
CI looks good, can you rebase and fix the conflict? |
|
@swolchok rebased |
|
unittest linux failures look ignorable |
Summary
Reopening from #11537
Fixes #11370
Test plan
Use existing tests since we are doing a drop-in replacement for overflow checks.