Skip to content

add custom annoatation for new model export #12126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

add custom annoatation for new model export #12126

merged 1 commit into from
Jul 2, 2025

Conversation

@billmguo
Copy link
Contributor

@billmguo billmguo commented Jul 1, 2025

Summary: add custom annoatation for new model export

Differential Revision: D77569950

@billmguo billmguo requested a review from cccclai as a code owner July 1, 2025 04:02
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12126

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Cancelled Jobs, 1 Unrelated Failure

As of commit b79262b with merge base 5cc5421 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 1, 2025

This pull request was exported from Phabricator. Differential Revision: D77569950

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@billmguo
Copy link
Contributor Author

billmguo commented Jul 1, 2025

@pytorchbot label "topic: not user facing"

@limintang limintang self-requested a review July 1, 2025 20:07
billmguo added a commit to billmguo/executorch that referenced this pull request Jul 1, 2025
@billmguo @facebook-github-bot
add custom annoatation for new model export (pytorch#12126)
f87a702 
Summary:

add  custom annoatation for new model export

Reviewed By: limintang

Differential Revision: D77569950
@billmguo billmguo force-pushed the export-D77569950 branch from 1fcbaf1 to f87a702 Compare July 1, 2025 22:02
billmguo added a commit to billmguo/executorch that referenced this pull request Jul 1, 2025
@billmguo @facebook-github-bot
add custom annoatation for new model export (pytorch#12126)
89e5a70 
Summary:

add  custom annoatation for new model export

Reviewed By: limintang

Differential Revision: D77569950
@billmguo billmguo force-pushed the export-D77569950 branch from f87a702 to 89e5a70 Compare July 1, 2025 22:03
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 1, 2025

This pull request was exported from Phabricator. Differential Revision: D77569950

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 1, 2025

This pull request was exported from Phabricator. Differential Revision: D77569950

billmguo added a commit to billmguo/executorch that referenced this pull request Jul 1, 2025
@billmguo @facebook-github-bot
add custom annoatation for new model export (pytorch#12126)
1952990 
Summary:
Pull Request resolved: pytorch#12126

add  custom annoatation for new model export

Reviewed By: limintang

Differential Revision: D77569950
@billmguo billmguo force-pushed the export-D77569950 branch from 89e5a70 to 1952990 Compare July 1, 2025 22:07
winskuo-quic
winskuo-quic approved these changes Jul 2, 2025
View reviewed changes
Copy link
Collaborator

@winskuo-quic winskuo-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

backends/qualcomm/_passes/lift_constant_scalar_operands.py Outdated
) -> Dict[int, TensorConstant]:
tensor_args = {}
for i, arg in enumerate(node.args):
if hasattr(node.target, "_schema"):
Copy link
Collaborator

@winskuo-quic winskuo-quic Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious under what situation a node has no schema.

Copy link
Contributor Author

@billmguo billmguo Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove this lines, this issue happen when I apply get_quant_embedding_transform for the model embedding layers and export model with -E "4,32"

@billmguo @facebook-github-bot
add custom annoatation for new model export (pytorch#12126)
b79262b 
Summary:

add  custom annoatation for new model export

Reviewed By: limintang

Differential Revision: D77569950
@billmguo billmguo force-pushed the export-D77569950 branch from 1952990 to b79262b Compare July 2, 2025 03:00
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 2, 2025

This pull request was exported from Phabricator. Differential Revision: D77569950

@facebook-github-bot facebook-github-bot merged commit bed504e into pytorch:main Jul 2, 2025
94 of 98 checks passed
BujSet pushed a commit to BujSet/executorch that referenced this pull request Jul 2, 2025
@billmguo @BujSet
add custom annoatation for new model export
5dedcb8 
Differential Revision: D77569950

Pull Request resolved: pytorch#12126
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
@billmguo @Tanish2101
add custom annoatation for new model export
5501515 
Differential Revision: D77569950

Pull Request resolved: pytorch#12126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@limintang limintang limintang approved these changes

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

@chunit-quic chunit-quic Awaiting requested review from chunit-quic

@haowhsu-quic haowhsu-quic Awaiting requested review from haowhsu-quic

@shewu-quic shewu-quic Awaiting requested review from shewu-quic

@DannyYuyang-quic DannyYuyang-quic Awaiting requested review from DannyYuyang-quic

+1 more reviewer

@winskuo-quic winskuo-quic winskuo-quic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@billmguo @facebook-github-bot @limintang @winskuo-quic