Arm backend: Add mean.dim to CheckProperQuantization #12127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mean.dim decomposes into an avg_pool2d, which occurs after quantization annotation. This led to the avg_pool2d node not having quantization parameters for the output. mean.dim is added to CheckProperQuantization so that if the decomposition occurs the avg_pool2d operator will not be delegated. Change-Id: I5c43530880e7f4cb99a2adaa2f250c0bf749aa8c Signed-off-by: Sebastian Larsson <[email protected]>
Sebastian-Larsson
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12127
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit b40cd8b with merge base 929ec94 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
approved these changes
Jul 1, 2025
zingo
reviewed
Jul 1, 2025
Collaborator
zingo
left a comment
zingo
left a comment
There was a problem hiding this comment.
Got a fail on
backends/arm/test/models/test_nn_functional.py::test_nn_functional_BI[cosine_similarity]
could it be random?
zingo
requested changes
Jul 1, 2025
Collaborator
zingo
left a comment
zingo
left a comment
There was a problem hiding this comment.
Try to retrigger to get rid of arm fail?
Collaborator
|
I retriggered fail arm job. |
zingo
approved these changes
Jul 2, 2025
BujSet
pushed a commit
to BujSet/executorch
that referenced
this pull request
Jul 2, 2025
mean.dim decomposes into an avg_pool2d, which occurs after quantization annotation. This led to the avg_pool2d node not having quantization parameters for the output. mean.dim is added to CheckProperQuantization so that if the decomposition occurs the avg_pool2d operator will not be delegated. Signed-off-by: Sebastian Larsson <[email protected]>
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
mean.dim decomposes into an avg_pool2d, which occurs after quantization annotation. This led to the avg_pool2d node not having quantization parameters for the output. mean.dim is added to CheckProperQuantization so that if the decomposition occurs the avg_pool2d operator will not be delegated. Signed-off-by: Sebastian Larsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mean.dim decomposes into an avg_pool2d, which occurs after quantization annotation. This led to the avg_pool2d node not having quantization parameters for the output. mean.dim is added to CheckProperQuantization so that if the decomposition occurs the avg_pool2d operator will not be delegated.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218