[Executorch][llm] Make mask tensor float only for sdpa #12131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we support quantized sdpa query tensor can be quantized and attention mask can be float (the only type allowed). So this check doesnt make sense anymore. Differential Revision: [D77516821](https://our.internmc.facebook.com/intern/diff/D77516821/) [ghstack-poisoned]
kimishpatel
requested review from
jackzhxng,
larryliu0820,
mergennachin and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12131
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled JobAs of commit 15b254c with merge base cf0bfd2 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jul 1, 2025
|
This pull request was exported from Phabricator. Differential Revision: D77516821 |
This PR needs a
|
metascroy
approved these changes
Jul 1, 2025
facebook-github-bot
merged commit 24bf2d3
into
gh/kimishpatel/195/base
94 of 100 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kimishpatel
added a commit
that referenced
this pull request
Jul 3, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #12131 by @kimishpatel ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/195/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/195/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/194/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/195/orig @diff-train-skip-merge --------- Co-authored-by: Kimish Patel <[email protected]>
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#12131 by @kimishpatel ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/195/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/195/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/194/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/195/orig @diff-train-skip-merge --------- Co-authored-by: Kimish Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Now that we support quantized sdpa query tensor can be quantized and attention mask can be float (the only type allowed).
So this check doesnt make sense anymore.
Differential Revision: D77516821