Skip to content

Conversation

@cccclai
Copy link
Contributor

@cccclai cccclai commented Jul 1, 2025

Summary: It often causes confusion and weird downstream error when the weight is not properly loaded. Set load_state_dict to be True so the error populated early.

Differential Revision: D77626023

Summary: It often causes confusion and weird downstream error when the weight is not properly loaded. Set `load_state_dict` to be True so the error populated early.

Differential Revision: D77626023
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12151

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Cancelled Jobs

As of commit 9285d24 with merge base 4e59c4e (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77626023

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Collaborator

@shewu-quic shewu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort.

@cccclai cccclai merged commit 1ccfdf4 into pytorch:main Jul 3, 2025
101 of 106 checks passed
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
Summary: It often causes confusion and weird downstream error when the
weight is not properly loaded. Set `load_state_dict` to be True so the
error populated early.

Differential Revision: D77626023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants