Added Pybindings for Method.h/cpp #12158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conarnar
requested review from
JacobSzwejbka,
larryliu0820,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12158
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Cancelled JobsAs of commit 71a28f8 with merge base 6da7bde ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77565018 |
Conarnar
added a commit
to Conarnar/executorch
that referenced
this pull request
Jul 2, 2025
Summary: Continuing with migrating the pybindings API to expose the lower level ET API rather than just the `Module` level. The next step of that is to add pybindings for `Method`. Bindings for the class Method and its methods `set_inputs`, `execute, get_outputs`, `get_attribute`, and `method_meta` were added along with `call` and `__call__` in order to easily call `set_inputs`, `execute`, and `get_outputs` all at once. The `method_meta` method for `Program` was also added. The `MethodMeta` binding was modified to include a shared reference to `Program` instead of `Module` if the `Module` API isn't used. The `Program` and `Method` classes in `__init__.py` were modified to hold their pybinding equivalent rather than Module. Differential Revision: D77565018
Conarnar
force-pushed
the
export-D77565018
branch
from
e5148d6 to
27cd708
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77565018 |
Conarnar
added a commit
to Conarnar/executorch
that referenced
this pull request
Jul 2, 2025
Summary: Continuing with migrating the pybindings API to expose the lower level ET API rather than just the `Module` level. The next step of that is to add pybindings for `Method`. Bindings for the class Method and its methods `set_inputs`, `execute, get_outputs`, `get_attribute`, and `method_meta` were added along with `call` and `__call__` in order to easily call `set_inputs`, `execute`, and `get_outputs` all at once. The `method_meta` method for `Program` was also added. The `MethodMeta` binding was modified to include a shared reference to `Program` instead of `Module` if the `Module` API isn't used. The `Program` and `Method` classes in `__init__.py` were modified to hold their pybinding equivalent rather than Module. Differential Revision: D77565018
Conarnar
force-pushed
the
export-D77565018
branch
from
27cd708 to
c891798
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77565018 |
Conarnar
added
release notes: none
Conarnar
force-pushed
the
export-D77565018
branch
from
c891798 to
b2a1132
Compare
Conarnar
added a commit
to Conarnar/executorch
that referenced
this pull request
Jul 3, 2025
Summary: Continuing with migrating the pybindings API to expose the lower level ET API rather than just the `Module` level. The next step of that is to add pybindings for `Method`. Bindings for the class Method and its methods `set_inputs`, `execute, get_outputs`, `get_attribute`, and `method_meta` were added along with `call` and `__call__` in order to easily call `set_inputs`, `execute`, and `get_outputs` all at once. The `method_meta` method for `Program` was also added. The `MethodMeta` binding was modified to include a shared reference to `Program` instead of `Module` if the `Module` API isn't used. The `Program` and `Method` classes in `__init__.py` were modified to hold their pybinding equivalent rather than Module. Differential Revision: D77565018
Conarnar
added a commit
to Conarnar/executorch
that referenced
this pull request
Jul 3, 2025
Summary: Continuing with migrating the pybindings API to expose the lower level ET API rather than just the `Module` level. The next step of that is to add pybindings for `Method`. Bindings for the class Method and its methods `set_inputs`, `execute, get_outputs`, `get_attribute`, and `method_meta` were added along with `call` and `__call__` in order to easily call `set_inputs`, `execute`, and `get_outputs` all at once. The `method_meta` method for `Program` was also added. The `MethodMeta` binding was modified to include a shared reference to `Program` instead of `Module` if the `Module` API isn't used. The `Program` and `Method` classes in `__init__.py` were modified to hold their pybinding equivalent rather than Module. Differential Revision: D77565018
Conarnar
force-pushed
the
export-D77565018
branch
from
b2a1132 to
366eb51
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77565018 |
Summary: Pull Request resolved: pytorch#12158 Continuing with migrating the pybindings API to expose the lower level ET API rather than just the `Module` level. The next step of that is to add pybindings for `Method`. Bindings for the class Method and its methods `set_inputs`, `execute, get_outputs`, `get_attribute`, and `method_meta` were added along with `call` and `__call__` in order to easily call `set_inputs`, `execute`, and `get_outputs` all at once. The `method_meta` method for `Program` was also added. The `MethodMeta` binding was modified to include a shared reference to `Program` instead of `Module` if the `Module` API isn't used. The `Program` and `Method` classes in `__init__.py` were modified to hold their pybinding equivalent rather than Module. Differential Revision: D77565018
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77565018 |
Conarnar
force-pushed
the
export-D77565018
branch
from
366eb51 to
71a28f8
Compare
lucylq
approved these changes
Jul 3, 2025
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
Differential Revision: D77565018 Pull Request resolved: pytorch#12158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Continuing with migrating the pybindings API to expose the lower level ET API rather than just the
Modulelevel. The next step of that is to add pybindings forMethod.Bindings for the class Method and its methods
set_inputs,execute, get_outputs,get_attribute, andmethod_metawere added along withcalland__call__in order to easily callset_inputs,execute, andget_outputsall at once.The
method_metamethod forProgramwas also added.The
MethodMetabinding was modified to include a shared reference toPrograminstead ofModuleif theModuleAPI isn't used.The
ProgramandMethodclasses in__init__.pywere modified to hold their pybinding equivalent rather than Module.Differential Revision: D77565018