Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

Summary: this diff brings xnnpack quantizer numeric debugging test back on updated torchao infra.

Reviewed By: jerryzh168

Differential Revision: D76842934

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12173

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 244d0d9 with merge base 56f68a8 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76842934

@Gasoonjia Gasoonjia added the release notes: none Do not include this in the release notes label Jul 2, 2025
Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jul 2, 2025
…es (pytorch#12173)

Summary:

this diff brings xnnpack quantizer numeric debugging test back on updated torchao infra.

Reviewed By: jerryzh168, mcr229

Differential Revision: D76842934
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76842934

…es (pytorch#12173)

Summary:

this diff brings xnnpack quantizer numeric debugging test back on updated torchao infra.

Reviewed By: jerryzh168, mcr229

Differential Revision: D76842934
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76842934

@facebook-github-bot facebook-github-bot merged commit a7091bf into pytorch:main Jul 2, 2025
94 of 98 checks passed
@Gasoonjia
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.7 -c bring-test-back

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 2, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: invalid choice: 'bring-test-back' (choose from 'regression', 'critical', 'fixnewfeature', 'docs', 'release')

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@Gasoonjia
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.7 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Jul 2, 2025
Differential Revision: D76842934

Pull Request resolved: #12173

(cherry picked from commit a7091bf)
@pytorchbot
Copy link
Collaborator

Cherry picking #12173

The cherry pick PR is at #12185 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
Differential Revision: D76842934

Pull Request resolved: pytorch#12173
for n_name in node_name_equip_with_output_observer
]
for from_node_source in repeated_from_node_source:
self.assertEqual(res_counter[from_node_source], 3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it 3 now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants