Skip to content

Conversation

@BujSet
Copy link
Contributor

@BujSet BujSet commented Jul 2, 2025

Summary

This added directory structure is recommended to allow Executorch to formally be built as a module for a Zephyr project. Please see the add zephyr/README.md for more details.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12174

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Pending

As of commit 0e23cb5 with merge base 22b9e59 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2025
@BujSet
Copy link
Contributor Author

BujSet commented Jul 2, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Jul 2, 2025
@BujSet BujSet requested a review from larryliu0820 July 2, 2025 21:12
@BujSet BujSet marked this pull request as ready for review July 2, 2025 21:12
@BujSet BujSet self-assigned this Jul 2, 2025
@larryliu0820
Copy link
Contributor

cc @mergennachin @digantdesai for this. I feel like this should be fine, we already have a lot top level directories anyways

@BujSet BujSet merged commit 02454eb into pytorch:main Jul 2, 2025
164 of 171 checks passed
@digantdesai
Copy link
Contributor

cc @mergennachin @digantdesai for this. I feel like this should be fine, we already have a lot top level directories anyways

"The module repository codebase shall include a module.yml file in a zephyr/ folder at the root of the repository." Seems like we don't have a choice. If we find one I would prefer hiding this from the top level, but no hard objection TBH.

@BujSet BujSet deleted the zephyr_module branch July 3, 2025 14:00
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
### Summary
This added directory structure is recommended to allow Executorch to
formally be built as a module for a Zephyr project. Please see the add
`zephyr/README.md` for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants