-
Notifications
You must be signed in to change notification settings - Fork 743
[RFC] Add TrainingModule and SGD JNI #12188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12188
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Cancelled Jobs, 1 Unrelated FailureAs of commit 9c80c53 with merge base 2f55193 ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@georgehong has imported this pull request. If you are a Meta employee, you can view this in D77702768. |
This PR needs a
|
fc8efa0 to
19da994
Compare
|
@georgehong has imported this pull request. If you are a Meta employee, you can view this in D77702768. |
19da994 to
19da644
Compare
|
@georgehong has imported this pull request. If you are a Meta employee, you can view this in D77702768. |
1 similar comment
|
@georgehong has imported this pull request. If you are a Meta employee, you can view this in D77702768. |
As title, adds wrappers together with unit test based on XOR train.cpp example.
In order to check correctness after XOR file preparation, temporarily push the files directly into the repo given the smaller size.
19da644 to
9c80c53
Compare
|
@georgehong has imported this pull request. If you are a Meta employee, you can view this in D77702768. |
As title, adds wrappers together with unit test based on XOR train.cpp example.
Summary
Adds JNI for SGD and TrainingModule, including a unit test that mirrors train.cpp for a simple XOR example. Also makes the following change:
Training dependencies are already enabled for Java JNI library, so we skip adding additional guard flags.
Test plan
Followed steps in README for extension/android, namely: