Skip to content

Conversation

@martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented Jul 3, 2025

Add explicit tests for per-channel quantization to all applicable operators (Convolutions and Linear ops). This is achieved by parametrizing the unit tests such that they both run per-channel and per-tensor quantization.

Test plan

The unit tests themselves are changed. Thus the code is tested.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Add explicit tests for per-channel quantization to all applicable
operators (Convolutions and Linear ops). This is achieved by
parametrizing the unit tests such that they both run per-channel and
per-tensor quantization.

Change-Id: I8b836d1e1d56b13e7046aba651fe401058e2858b
@martinlsm martinlsm requested a review from digantdesai as a code owner July 3, 2025 08:35
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12192

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 0c4b4f1 with merge base 29858b4 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jul 3, 2025
@martinlsm
Copy link
Collaborator Author

@Label ciflow/trunk

@zingo zingo added ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Jul 3, 2025
@zingo
Copy link
Collaborator

zingo commented Jul 3, 2025

failed test fails on other PR and on main also

@zingo zingo merged commit b2af630 into pytorch:main Jul 3, 2025
195 of 200 checks passed
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
Add explicit tests for per-channel quantization to all applicable
operators (Convolutions and Linear ops). This is achieved by
parametrizing the unit tests such that they both run per-channel and
per-tensor quantization.

### Test plan
The unit tests themselves are changed. Thus the code is tested.

Co-authored-by: Martin Lindström <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants