[ET-VK][ez] Fix partitioner logic #12194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SS-JIA
pushed a commit
that referenced
this pull request
Jul 3, 2025
Summary: ## Changes * In partitioner, check if buffer storage can be used only after it has been determined that no valid texture layouts are available ## Context Currently, the logic in the vulkan partitioner is incorrect. 1. First, it checks what texture layouts may be used to represent the tensors involved in the computation 2. If no texture layouts are available, it checks if buffer support is available and the tensors are small enough to be within Vulkan buffer limits 3. Then, it checks if all valid texture layouts are supported by the op. This introduces a bug in situations where 3 fails, but 2 would pass. However, 2 is not checked due to the way the logic is structured. The fix is to switch the order of 2 and 3. Test Plan: ## Test Plan Manual verification + CI ghstack-source-id: 9ccc526 Pull Request resolved: #12194
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12194
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This PR needs a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Changes
Context
Currently, the logic in the vulkan partitioner is incorrect.
This introduces a bug in situations where 3 fails, but 2 would pass. However, 2 is not checked due to the way the logic is structured.
The fix is to switch the order of 2 and 3.
Test Plan:
Test Plan
Manual verification + CI