-
Notifications
You must be signed in to change notification settings - Fork 700
Resubmission of Arm backend: Split executor runner into init + run #12197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Refactor the main function of arm_executor_runner.cpp by extracting code that is related to initializing and running a model into two separate helper functions (runner_init and RunnerContext::run). A new struct called RunnerContext is introduced to store data/context required to run the model. Change-Id: Iaca06d6f12b84644ce76e23e8881787a7971cdaa
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12197
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 2 Unrelated FailuresAs of commit 1f75e0f with merge base 5f70823 ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "partner: arm" |
|
@pytorchbot label ciflow/trunk |
|
Hi @digantdesai @metascroy as we don't know the original error this was reverted for we do not know if the rebase we did will solve this. E.g. We had to do some small change in the rebase as another PR landed in the same file. |
Let me try importing and re-running to see if the error still exists. It might have been transient. |
|
@metascroy has imported this pull request. If you are a Meta employee, you can view this in D77872847. |
Things look good on internal tests, so let's try re-landing. |
…ytorch#12197) The PR pytorch#12162 got reverted with pytorch#12171. This PR is a resubmission of the patch. Refactor the main function of arm_executor_runner.cpp by extracting code that is related to initializing and running a model into two separate helper functions (runner_init and RunnerContext::run). A new struct called RunnerContext is introduced to store data/context required to run the model. ### Test plan Arm's CI runs and tests the changed code. Co-authored-by: Martin Lindström <[email protected]>
The PR #12162 got reverted with #12171. This PR is a resubmission of the patch.
Refactor the main function of arm_executor_runner.cpp by extracting code that is related to initializing and running a model into two separate helper functions (runner_init and RunnerContext::run). A new struct called RunnerContext is introduced to store data/context required to run the model.
Test plan
Arm's CI runs and tests the changed code.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218