Skip to content

Conversation

@martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented Jul 3, 2025

The PR #12162 got reverted with #12171. This PR is a resubmission of the patch.

Refactor the main function of arm_executor_runner.cpp by extracting code that is related to initializing and running a model into two separate helper functions (runner_init and RunnerContext::run). A new struct called RunnerContext is introduced to store data/context required to run the model.

Test plan

Arm's CI runs and tests the changed code.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Refactor the main function of arm_executor_runner.cpp by extracting code
that is related to initializing and running a model into two separate
helper functions (runner_init and RunnerContext::run). A new struct
called RunnerContext is introduced to store data/context required to run
the model.

Change-Id: Iaca06d6f12b84644ce76e23e8881787a7971cdaa
@martinlsm martinlsm requested a review from digantdesai as a code owner July 3, 2025 14:41
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12197

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 2 Unrelated Failures

As of commit 1f75e0f with merge base 5f70823 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jul 3, 2025
@martinlsm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@zingo zingo added the release notes: arm Changes to the ARM backend delegate label Jul 3, 2025
@zingo
Copy link
Collaborator

zingo commented Jul 3, 2025

Hi @digantdesai @metascroy as we don't know the original error this was reverted for we do not know if the rebase we did will solve this. E.g. We had to do some small change in the rebase as another PR landed in the same file.
Will you check this first or do we retry a merge tomorrow and see what happens?

@metascroy
Copy link
Contributor

Hi @digantdesai @metascroy as we don't know the original error this was reverted for we do not know if the rebase we did will solve this. E.g. We had to do some small change in the rebase as another PR landed in the same file. Will you check this first or do we retry a merge tomorrow and see what happens?

Let me try importing and re-running to see if the error still exists. It might have been transient.

@facebook-github-bot
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D77872847.

@metascroy
Copy link
Contributor

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D77872847.

Things look good on internal tests, so let's try re-landing.

@zingo zingo merged commit 487da8c into pytorch:main Jul 7, 2025
201 of 209 checks passed
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
…ytorch#12197)

The PR pytorch#12162 got reverted with pytorch#12171. This PR is a resubmission of the
patch.

Refactor the main function of arm_executor_runner.cpp by extracting code
that is related to initializing and running a model into two separate
helper functions (runner_init and RunnerContext::run). A new struct
called RunnerContext is introduced to store data/context required to run
the model.

### Test plan
Arm's CI runs and tests the changed code.

Co-authored-by: Martin Lindström <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants