Binary Comparison Ops #12198
Merged
Binary Comparison Ops #12198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12198
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 646e6f9 with merge base aaf0a4c ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76049244 |
andreanicastro
force-pushed
the
export-D76049244
branch
from
957e821 to
a1d934f
Compare
This PR needs a
|
andreanicastro
added
the
module: vulkan
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76049244 |
andreanicastro
force-pushed
the
export-D76049244
branch
from
a1d934f to
569e3ec
Compare
andreanicastro
added a commit
to andreanicastro/executorch
that referenced
this pull request
Jul 3, 2025
Summary: Pull Request resolved: pytorch#12198 This change introduces the `binary_eq`, `binary_lt`, `binary_le`, `binary_gt`, `binary_ge` operators. 1. Introduced the operators in the binary_op.yaml file 2. we now store the shader variant base name to better handle special cases in the glsl of binary op 3. binary ops assumed that the output of the operation is the same of the input data. For `binary_eq` this is not true. This is now handled both in the shader and the in the graph creation. 4. added test case Reviewed By: SS-JIA Differential Revision: D76049244
andreanicastro
added a commit
to andreanicastro/executorch
that referenced
this pull request
Jul 3, 2025
Summary: This change introduces the `binary_eq`, `binary_lt`, `binary_le`, `binary_gt`, `binary_ge` operators. 1. Introduced the operators in the binary_op.yaml file 2. we now store the shader variant base name to better handle special cases in the glsl of binary op 3. binary ops assumed that the output of the operation is the same of the input data. For `binary_eq` this is not true. This is now handled both in the shader and the in the graph creation. 4. added test case Reviewed By: SS-JIA Differential Revision: D76049244
andreanicastro
force-pushed
the
export-D76049244
branch
from
569e3ec to
0b0e0f3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76049244 |
andreanicastro
force-pushed
the
export-D76049244
branch
from
0b0e0f3 to
f90c88d
Compare
andreanicastro
added a commit
to andreanicastro/executorch
that referenced
this pull request
Jul 3, 2025
Summary: Pull Request resolved: pytorch#12198 This change introduces the `binary_eq`, `binary_lt`, `binary_le`, `binary_gt`, `binary_ge` operators. 1. Introduced the operators in the binary_op.yaml file 2. we now store the shader variant base name to better handle special cases in the glsl of binary op 3. binary ops assumed that the output of the operation is the same of the input data. For `binary_eq` this is not true. This is now handled both in the shader and the in the graph creation. 4. added test case Reviewed By: SS-JIA Differential Revision: D76049244
andreanicastro
added a commit
to andreanicastro/executorch
that referenced
this pull request
Jul 7, 2025
Summary: This change introduces the `binary_eq`, `binary_lt`, `binary_le`, `binary_gt`, `binary_ge` operators. 1. Introduced the operators in the binary_op.yaml file 2. we now store the shader variant base name to better handle special cases in the glsl of binary op 3. binary ops assumed that the output of the operation is the same of the input data. For `binary_eq` this is not true. This is now handled both in the shader and the in the graph creation. 4. added test case Reviewed By: SS-JIA Differential Revision: D76049244
andreanicastro
force-pushed
the
export-D76049244
branch
from
f90c88d to
65ae910
Compare
andreanicastro
added a commit
to andreanicastro/executorch
that referenced
this pull request
Jul 7, 2025
Summary: This change introduces the `binary_eq`, `binary_lt`, `binary_le`, `binary_gt`, `binary_ge` operators. 1. Introduced the operators in the binary_op.yaml file 2. we now store the shader variant base name to better handle special cases in the glsl of binary op 3. binary ops assumed that the output of the operation is the same of the input data. For `binary_eq` this is not true. This is now handled both in the shader and the in the graph creation. 4. added test case Reviewed By: SS-JIA Differential Revision: D76049244
andreanicastro
force-pushed
the
export-D76049244
branch
from
65ae910 to
4cd70a7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76049244 |
andreanicastro
added a commit
to andreanicastro/executorch
that referenced
this pull request
Jul 7, 2025
Summary: Pull Request resolved: pytorch#12198 This change introduces the `binary_eq`, `binary_lt`, `binary_le`, `binary_gt`, `binary_ge` operators. 1. Introduced the operators in the binary_op.yaml file 2. we now store the shader variant base name to better handle special cases in the glsl of binary op 3. binary ops assumed that the output of the operation is the same of the input data. For `binary_eq` this is not true. This is now handled both in the shader and the in the graph creation. 4. added test case Reviewed By: SS-JIA Differential Revision: D76049244
andreanicastro
force-pushed
the
export-D76049244
branch
from
4cd70a7 to
7a92af7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76049244 |
andreanicastro
added a commit
to andreanicastro/executorch
that referenced
this pull request
Jul 7, 2025
Summary: Pull Request resolved: pytorch#12198 This change introduces the `binary_eq`, `binary_lt`, `binary_le`, `binary_gt`, `binary_ge` operators. 1. Introduced the operators in the binary_op.yaml file 2. we now store the shader variant base name to better handle special cases in the glsl of binary op 3. binary ops assumed that the output of the operation is the same of the input data. For `binary_eq` this is not true. This is now handled both in the shader and the in the graph creation. 4. added test case Reviewed By: SS-JIA Differential Revision: D76049244
andreanicastro
force-pushed
the
export-D76049244
branch
from
7a92af7 to
cbe1c59
Compare
SS-JIA
approved these changes
Jul 8, 2025
andreanicastro
force-pushed
the
export-D76049244
branch
from
cbe1c59 to
6fbbec2
Compare
andreanicastro
added a commit
to andreanicastro/executorch
that referenced
this pull request
Jul 8, 2025
Summary: This change introduces the `binary_eq`, `binary_lt`, `binary_le`, `binary_gt`, `binary_ge` operators. 1. Introduced the operators in the binary_op.yaml file 2. we now store the shader variant base name to better handle special cases in the glsl of binary op 3. binary ops assumed that the output of the operation is the same of the input data. For `binary_eq` this is not true. This is now handled both in the shader and the in the graph creation. 4. added test case Reviewed By: SS-JIA Differential Revision: D76049244
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76049244 |
andreanicastro
added a commit
to andreanicastro/executorch
that referenced
this pull request
Jul 8, 2025
Summary: Pull Request resolved: pytorch#12198 This change introduces the `binary_eq`, `binary_lt`, `binary_le`, `binary_gt`, `binary_ge` operators. 1. Introduced the operators in the binary_op.yaml file 2. we now store the shader variant base name to better handle special cases in the glsl of binary op 3. binary ops assumed that the output of the operation is the same of the input data. For `binary_eq` this is not true. This is now handled both in the shader and the in the graph creation. 4. added test case Reviewed By: SS-JIA Differential Revision: D76049244
andreanicastro
force-pushed
the
export-D76049244
branch
from
6fbbec2 to
03e65da
Compare
Differential Revision: D77229915
andreanicastro
force-pushed
the
export-D76049244
branch
from
03e65da to
a70da84
Compare
andreanicastro
added a commit
to andreanicastro/executorch
that referenced
this pull request
Jul 10, 2025
Summary: This change introduces the `binary_eq`, `binary_lt`, `binary_le`, `binary_gt`, `binary_ge` operators. 1. Introduced the operators in the binary_op.yaml file 2. we now store the shader variant base name to better handle special cases in the glsl of binary op 3. binary ops assumed that the output of the operation is the same of the input data. For `binary_eq` this is not true. This is now handled both in the shader and the in the graph creation. 4. added test case Reviewed By: SS-JIA Differential Revision: D76049244
Summary: Pull Request resolved: pytorch#12198 This change introduces the `binary_eq`, `binary_lt`, `binary_le`, `binary_gt`, `binary_ge` operators. 1. Introduced the operators in the binary_op.yaml file 2. we now store the shader variant base name to better handle special cases in the glsl of binary op 3. binary ops assumed that the output of the operation is the same of the input data. For `binary_eq` this is not true. This is now handled both in the shader and the in the graph creation. 4. added test case Reviewed By: SS-JIA Differential Revision: D76049244
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76049244 |
andreanicastro
force-pushed
the
export-D76049244
branch
from
a70da84 to
646e6f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change introduces the
binary_eq,binary_lt,binary_le,binary_gt,binary_geoperators.binary_eqthis is not true. This is now handled both in the shader and the in the graph creation.Reviewed By: SS-JIA
Differential Revision: D76049244
cc @SS-JIA @manuelcandales @cbilgin