Skip to content

Conversation

@jathu
Copy link
Contributor

@jathu jathu commented Jul 7, 2025

Summary

What are the benefits of looking for the system buck2?

  • I'm guessing only Meta engineers have buck2 pre-installed, and the internal version doesn't work with ET — it fails looking for a .buck2 file
  • If someone really wants to use their system buck2, they can use the BUCK2 cmake arg

Test plan

CI

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels Jul 7, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12245

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 Cancelled Jobs, 1 Pending

As of commit db40054 with merge base 6669637 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 7, 2025
@jathu jathu force-pushed the jathu/always-get-buck2 branch from f967cce to db40054 Compare July 7, 2025 16:19
@jathu jathu marked this pull request as ready for review July 7, 2025 16:54
@jathu jathu requested a review from mergennachin July 7, 2025 16:54
@jathu jathu merged commit 557b4de into main Jul 7, 2025
207 of 212 checks passed
@jathu jathu deleted the jathu/always-get-buck2 branch July 7, 2025 19:45
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
### Summary
What are the benefits of looking for the system buck2? 

* I'm guessing only Meta engineers have buck2 pre-installed, and the
internal version doesn't work with ET — it fails looking for a `.buck2`
file
* If someone really wants to use their system buck2, they can use the
BUCK2 cmake arg

### Test plan

CI

cc @larryliu0820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants