Skip to content

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Jul 7, 2025

This landed internally and PR #12099 closed, but the bot couldn't pick it. Here's a manual pick.

Differential Revision: D76831122

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jul 7, 2025

Stack from ghstack (oldest at bottom):

@swolchok swolchok requested a review from manuelcandales as a code owner July 7, 2025 16:49
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12246

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 9 Pending

As of commit 3985667 with merge base 6669637 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jul 7, 2025
This landed internally and PR #12099 closed, but the bot couldn't pick it. Here's a manual pick.

Differential Revision: D76831122


ghstack-source-id: 721fa97
ghstack-comment-id: 3045906835
Pull-Request-resolved: #12246
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 7, 2025
@swolchok swolchok requested a review from metascroy July 7, 2025 16:49
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jul 7, 2025
@swolchok
Copy link
Contributor Author

swolchok commented Jul 7, 2025

test-llava-runner-linux is known to intermittently segfault (we should really fix that sometime...), but this has already gone through CI and landed once and is just a cherry-pick so I will merge as soon as unittest jobs come back

@swolchok swolchok merged commit c778063 into main Jul 7, 2025
95 of 99 checks passed
@swolchok swolchok deleted the gh/swolchok/497/head branch July 7, 2025 17:19
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
This landed internally and PR
pytorch#12099 closed, but the bot
couldn't pick it. Here's a manual pick.

Differential Revision: D76831122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants