Updated the comparison logic to handle sequences separately #12251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12251
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 321bc98 with merge base 264ac90 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77893628 |
Contributor
Author
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
Juntian777
force-pushed
the
export-D77893628
branch
from
8a33c41 to
bf60729
Compare
Juntian777
pushed a commit
to Juntian777/executorch
that referenced
this pull request
Jul 8, 2025
…12251) Summary: Previously, the numerical comparators were designed to compare two inputs regardless of whether they were sequences, which involved stacking a list of tensors into one for comparison. The updated logic now restricts comparators to only compare two tensors at a time, with sequence handling managed externally. Differential Revision: D77893628
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77893628 |
Juntian777
force-pushed
the
export-D77893628
branch
from
bf60729 to
be68445
Compare
Juntian777
pushed a commit
to Juntian777/executorch
that referenced
this pull request
Jul 8, 2025
…12251) Summary: Previously, the numerical comparators were designed to compare two inputs regardless of whether they were sequences, which involved stacking a list of tensors into one for comparison. The updated logic now restricts comparators to only compare two tensors at a time, with sequence handling managed externally. Reviewed By: Gasoonjia Differential Revision: D77893628
Juntian777
pushed a commit
to Juntian777/executorch
that referenced
this pull request
Jul 8, 2025
…12251) Summary: Previously, the numerical comparators were designed to compare two inputs regardless of whether they were sequences, which involved stacking a list of tensors into one for comparison. The updated logic now restricts comparators to only compare two tensors at a time, with sequence handling managed externally. Reviewed By: Gasoonjia Differential Revision: D77893628
Juntian777
force-pushed
the
export-D77893628
branch
from
be68445 to
263dd38
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77893628 |
…12251) Summary: Pull Request resolved: pytorch#12251 Previously, the numerical comparators were designed to compare two inputs regardless of whether they were sequences, which involved stacking a list of tensors into one for comparison. The updated logic now restricts comparators to only compare two tensors at a time, with sequence handling managed externally. Reviewed By: Gasoonjia Differential Revision: D77893628
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77893628 |
Juntian777
force-pushed
the
export-D77893628
branch
from
263dd38 to
321bc98
Compare
Gasoonjia
approved these changes
Jul 8, 2025
Tanish2101
pushed a commit
to Tanish2101/executorch
that referenced
this pull request
Jul 9, 2025
Differential Revision: D77893628 Pull Request resolved: pytorch#12251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously, the numerical comparators were designed to compare two inputs regardless of whether they were sequences, which involved stacking a list of tensors into one for comparison. The updated logic now restricts comparators to only compare two tensors at a time, with sequence handling managed externally.
Differential Revision: D77893628