Skip to content

Conversation

@pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11997 by @Gasoonjia
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/17/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/17/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/17/orig
@diff-train-skip-merge

…ed graph instead of edge program

Pull Request resolved: #11997

This diff update the debug handle generation, from each node in the edge program having a individual debug handle, to all nodes having a same ancestor in export graph sharing a same debug handle, which update the start point of tracing our node transformation from edge graph to exported graph generated from nn.Module, by using `from_node` as source. N6213836 is an example of how `from_node` infra works.

After this diff every node sharing the same ancestor node in export graph will have same debug handle.

Before this diff:
 {F1979833525}

After this diff:
{F1979833595}

and if quantized:
{F1979833708}

Beyond that, placeholder and output node will no longer have debug handle.

ghstack-source-id: 294784602
@exported-using-ghexport

Differential Revision: [D76860368](https://our.internmc.facebook.com/intern/diff/D76860368/)
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12275

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit ef680a1 with merge base b342f83 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 8, 2025
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@psiddh psiddh merged commit 5eb14b7 into main Jul 8, 2025
96 of 98 checks passed
@psiddh psiddh deleted the gh/gasoonjia/17/orig branch July 8, 2025 19:01
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: pytorch#11997 by
@Gasoonjia
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/17/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/17/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/17/orig
@diff-train-skip-merge

Co-authored-by: gasoonjia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants