Update comment on deprecation warning to point inernal users to use safer API #12318
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12318
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Unrelated FailuresAs of commit 0ebece0 with merge base b5f950b ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77973302 |
This PR needs a
|
extension/threadpool/threadpool.h
Outdated
| * to run the model on. | ||
| */ | ||
| [[deprecated("This API is experimental and may change without notice.")]] | ||
| [[deprecated("This API is experimental and may change without notice. Consider using UseNThreadsThreadPoolGuard")]] |
There was a problem hiding this comment.
nit: period at end of sentence.
There was a problem hiding this comment.
good point. forgot about this.
…afer API (pytorch#12318) Summary: For Meta internal use there is UseNThreadsThreadPoolGuard API to allow users to use a subset of threads. Point users to this API. Created from CodeHub with https://fburl.com/edit-in-codehub Reviewed By: swolchok Differential Revision: D77973302
kimishpatel
force-pushed
the
export-D77973302
branch
from
80e8895 to
0ebece0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77973302 |
3 participants
Summary:
For Meta internal use there is UseNThreadsThreadPoolGuard API to allow users to use a subset of threads. Point users to this API.
Created from CodeHub with https://fburl.com/edit-in-codehub
Reviewed By: swolchok
Differential Revision: D77973302