Bump transformer version and fix Llava example #12324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12324
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 54c6f2d with merge base aec1322 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
added
the
release notes: none
larryliu0820
force-pushed
the
bump_transformer
branch
from
0ac82d0 to
dfa483a
Compare
lucylq
approved these changes
Jul 10, 2025
A lot has changed on Llava, this PR: * Change the state dict key mapping to match the new Llava model definition in HF. * Use the `processor.apply_chat_template()` API to get `input_id`s so that we can be a bit more resilient to input_id format changes.
larryliu0820
force-pushed
the
bump_transformer
branch
from
d94fa1c to
54c6f2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot has changed on Llava model definition between 4.47 to 4.52, this PR:
processor.apply_chat_template()API to getinput_ids so that we can be a bit more resilient to input_id format changes.