Skip to content

Conversation

@YufengShi-dudu
Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu commented Jul 11, 2025

  • Disable mlsdk setup by default because the manifest repo is not yet public.
  • To enable mlsdk dependencies, an mlsdk_manifest_url needs to be supplied. This setup is currently intended for internal development only.

Change-Id: I708e3f8c611dfc31b1f9a44212132c1ff7a79e0e

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Disable mlsdk setup by default because the manifest repo is
  not yet public.
- To enable mlsdk dependencies, an mlsdk_manifest_url needs to
  be supplied. This setup is currently intended for internal
  development only.

Change-Id: I708e3f8c611dfc31b1f9a44212132c1ff7a79e0e
Signed-off-by: Yufeng Shi <[email protected]>
Co-authored-by: Rob Elliott <[email protected]>
Co-authored-by: Ryan O'Shea <[email protected]>
Co-authored-by: Yufeng Shi <[email protected]>
@YufengShi-dudu YufengShi-dudu added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Jul 11, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12397

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (7 Unrelated Failures)

As of commit a7831d2 with merge base f82c2f0 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2025
@YufengShi-dudu YufengShi-dudu requested a review from per July 11, 2025 13:18
Copy link
Collaborator

@robell robell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended on internal workloads - this is fine until the final manifest gets upstream.

@YufengShi-dudu
Copy link
Collaborator Author

Failures are unrelated to this patch.
Ready to merge.

Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@Sebastian-Larsson Sebastian-Larsson merged commit 2bd96df into pytorch:main Jul 14, 2025
197 of 204 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants