Skip to content

Remove usages of 'to_edge_with_preserve_ops' #12471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2025
Merged

Remove usages of 'to_edge_with_preserve_ops' #12471

merged 3 commits into from
Jul 17, 2025

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Jul 15, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Replace with to_edge.

Differential Revision: D78311705

@lucylq
Remove usages of 'to_edge_with_preserve_ops'
44da050 
Replace with to_edge.

Differential Revision: [D78311705](https://our.internmc.facebook.com/intern/diff/D78311705/)

[ghstack-poisoned]
@lucylq lucylq requested review from cccclai and metascroy as code owners July 15, 2025 00:35
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12471

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 57569b5 with merge base 46ca782 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 15, 2025
Merged
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78311705

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq
Update on "Remove usages of 'to_edge_with_preserve_ops'"
cfdd6c5 
Replace with to_edge.

Differential Revision: [D78311705](https://our.internmc.facebook.com/intern/diff/D78311705/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78311705

@lucylq
Update on "Remove usages of 'to_edge_with_preserve_ops'"
57569b5 
Replace with to_edge.

Differential Revision: [D78311705](https://our.internmc.facebook.com/intern/diff/D78311705/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Jul 16, 2025
@lucylq
Remove usages of 'to_edge_with_preserve_ops'
ddeb786 
Pull Request resolved: #12471

Replace with to_edge.
ghstack-source-id: 296680655
@exported-using-ghexport

Differential Revision: [D78311705](https://our.internmc.facebook.com/intern/diff/D78311705/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78311705

@facebook-github-bot facebook-github-bot merged commit ff825e4 into gh/lucylq/91/base Jul 17, 2025
103 of 107 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/lucylq/91/head branch July 17, 2025 16:41
lucylq added a commit that referenced this pull request Jul 17, 2025
@lucylq
Remove usages of 'to_edge_with_preserve_ops'
f5405a6 
Differential Revision: D78311705

Pull Request resolved: #12471
@lucylq lucylq mentioned this pull request Jul 17, 2025
Merged
lucylq added a commit that referenced this pull request Jul 17, 2025
@lucylq @pytorchbot
Remove usages of 'to_edge_with_preserve_ops' #12471 (#12595)
94c4156 
#12471

GH bot failed to create PR to main..

---------

Co-authored-by: pytorchbot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@cccclai cccclai Awaiting requested review from cccclai

@metascroy metascroy Awaiting requested review from metascroy

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucylq @facebook-github-bot @larryliu0820