[ET-VK] Adding push constant and ubo verison of select and slice ops to improve memory and performance. #12508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…return a default if value at index is none. Pull Request resolved: #12357 This diff adds a new function `extract_scalar_or` to the `ComputeGraph` class, which extracts a scalar value from a `ValueRef` index. If the value at the index is `None`, it returns a default value. ghstack-source-id: 296319453 @exported-using-ghexport Differential Revision: [D78094858](https://our.internmc.facebook.com/intern/diff/D78094858/)
…to improve memory and performance. Pull Request resolved: #12358 Adding push constant and ubo verison of select and slice ops to improve memory and performance. * Updated `transfer_buffer.yaml` and `transfer_texture.yaml` to include `UBO_PARAMS` parameter and generate variants for `select` and `slice` ops with UBO parameters. * Updated `transfer.glsl` to generate ubo and push constant versions of `select` and `slice` ops with UBO parameters. ghstack-source-id: 296319454 Differential Revision: [D78095262](https://our.internmc.facebook.com/intern/diff/D78095262/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12508
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 82 PendingAs of commit 2d8f1f6 with merge base 46ca782 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
SS-JIA
approved these changes
Jul 15, 2025
lucylq
pushed a commit
that referenced
this pull request
Jul 17, 2025
…to improve memory and performance. (#12508) Adding push constant and ubo verison of select and slice ops to improve memory and performance. * Updated `transfer_buffer.yaml` and `transfer_texture.yaml` to include `UBO_PARAMS` parameter and generate variants for `select` and `slice` ops with UBO parameters. * Updated `transfer.glsl` to generate ubo and push constant versions of `select` and `slice` ops with UBO parameters. Differential Revision: [D78095262](https://our.internmc.facebook.com/intern/diff/D78095262/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #12358 by @trivedivivek
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/118/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/118/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/117/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/118/orig
@diff-train-skip-merge