Skip to content

[ET-VK] 6/n Split dispatches between multiple command buffers. Repurpose submit_current_cmd_and_wait to wait based on input flag. #12529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: gh/trivedivivek/126/base
Choose a base branch
from
Open

[ET-VK] 6/n Split dispatches between multiple command buffers. Repurpose submit_current_cmd_and_wait to wait based on input flag. #12529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
249984c
[ET-VK] 6/n Split dispatches between multiple command buffers. Repurp…
trivedivivek Jul 15, 2025
0cae4a4
Update on "[ET-VK] 6/n Split dispatches between multiple command buff…
trivedivivek Jul 15, 2025
c103fd7
Update on "[ET-VK] 6/n Split dispatches between multiple command buff…
trivedivivek Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions backends/vulkan/runtime/graph/ComputeGraph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,15 +756,16 @@ void ComputeGraph::prepare_pipelines() {
vkapi::ComputePipelineCache::Hasher>();
}

void ComputeGraph::submit_current_cmd(const bool final_use) {
context_->submit_cmd_to_gpu(VK_NULL_HANDLE, final_use);
}

void ComputeGraph::submit_current_cmd_and_wait(const bool final_use) {
vkapi::VulkanFence fence = context_->fences().get_fence();
context_->submit_cmd_to_gpu(fence.get_submit_handle(), final_use);
fence.wait();
context_->fences().return_fence(fence);
void ComputeGraph::submit_current_cmd(const bool final_use, bool wait) {
if (wait) {
// Submit and wait for command buffer
vkapi::VulkanFence fence = context_->fences().get_fence();
context_->submit_cmd_to_gpu(fence.get_submit_handle(), final_use);
fence.wait();
context_->fences().return_fence(fence);
} else {
context_->submit_cmd_to_gpu(VK_NULL_HANDLE, final_use);
}
}

void ComputeGraph::prepack() {
Expand All @@ -786,10 +787,10 @@ void ComputeGraph::prepack() {
// proceed. This results in lower load latency at the cost of higher peak
// memory usage.
if (reduce_peak_memory) {
submit_current_cmd_and_wait();
submit_current_cmd(/*final_use=*/true, /*wait=*/true);
context_->flush();
} else {
submit_current_cmd();
submit_current_cmd(/*final_use=*/true, /*wait=*/false);
}
staging_nbytes_in_cmd_ = 0;
context_->set_cmd();
Expand All @@ -799,7 +800,7 @@ void ComputeGraph::prepack() {
node->encode(this);
i++;
}
submit_current_cmd_and_wait(/*final_use=*/true);
submit_current_cmd(/*final_use=*/true, /*wait=*/true);
context_->flush();
staging_nbytes_in_cmd_ = 0;
}
Expand All @@ -821,7 +822,7 @@ void ComputeGraph::encode_execute() {

void ComputeGraph::execute() {
if (execute_pending_first_submission) {
submit_current_cmd_and_wait(/*final_use=*/false);
submit_current_cmd(/*final_use=*/false, /*wait=*/true);
execute_pending_first_submission = false;
} else {
vkapi::VulkanFence fence = context_->fences().get_fence();
Expand Down
9 changes: 2 additions & 7 deletions backends/vulkan/runtime/graph/ComputeGraph.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,16 +844,11 @@ class ComputeGraph final {
protected:
// Command Buffer Management

/*
* Submits the current command buffer in the Context to the GPU for execution.
*/
void submit_current_cmd(const bool final_use = false);

/*
* Submits the current command buffer in the Context to the GPU for execution,
* and wait for it to complete before returning.
* and wait for it to complete before returning, if wait is True.
*/
void submit_current_cmd_and_wait(const bool final_use = false);
void submit_current_cmd(const bool final_use = false, bool wait = true);

public:
//
Expand Down
Loading