Skip to content

Conversation

@metascroy
Copy link
Contributor

@metascroy metascroy commented Jul 16, 2025

This creates several improvements for the CoreML partitioner:

  • We now log when nodes are skipped for partitioning and the reason they are skipped.
  • We add new partitioner option lower_full_graph that raises Exception if the model cannot be fully delegated. In future, when this option is enabled we plan to support additional CoreML features like enumerated shapes.
  • We add take_over_constant_data option to tell CoreML delegate to not consume weight data.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12532

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 1b7b121 with merge base 6c51181 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@metascroy metascroy requested a review from YifanShenSZ July 16, 2025 17:00
@metascroy metascroy marked this pull request as ready for review July 16, 2025 17:00
@metascroy
Copy link
Contributor Author

@JacobSzwejbka this adds take_over_constant_data to partitioner. If you don't want CoreML to consume the weights, you can set it to False.

@metascroy metascroy force-pushed the coreml-partitioner-improvements branch from 06c3541 to 0ffbbb6 Compare July 17, 2025 22:53
Copy link
Collaborator

@YifanShenSZ YifanShenSZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀 These were the pain points we've been having during development, nice to see them enhanced!

@metascroy metascroy merged commit 31c276d into main Jul 18, 2025
105 of 108 checks passed
@metascroy metascroy deleted the coreml-partitioner-improvements branch July 18, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants