-
Notifications
You must be signed in to change notification settings - Fork 751
CoreML partitioner improvements #12532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12532
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 1b7b121 with merge base 6c51181 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@JacobSzwejbka this adds take_over_constant_data to partitioner. If you don't want CoreML to consume the weights, you can set it to False. |
06c3541 to
0ffbbb6
Compare
YifanShenSZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🚀 These were the pain points we've been having during development, nice to see them enhanced!
This creates several improvements for the CoreML partitioner: