Skip to content

Conversation

@winskuo-quic
Copy link
Collaborator

…(#12166)"

This reverts commit 9554826.

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

@pytorch-bot pytorch-bot bot added the ci-no-td label Jul 16, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12536

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit dffd733 with merge base 0c8879e (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@winskuo-quic winskuo-quic requested a review from cccclai as a code owner July 16, 2025 08:27
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
Sorry for the late reland on: #12166
I have been working on finding the root cause of timeout for certain models in this PR: #12191.
With the same config, it took only 1 minute to lower the model on my workstation. That is why I think higher timeout won't help resolving the issue.
In this PR with newest mainline, the CI seems to be working fine again.
However, I still couldn't find the reason that is causing the previous hang.
By any chance, can you see additional logs causing the hang on your side for this PR? #12191
I think if the root cause can be found, we can better prevent timeout from happening again in the future.
The model that is hanging previously was deit and dit.

@cccclai
Copy link
Contributor

cccclai commented Jul 28, 2025

After discussion offline, we will remove the timeout model and only enable the pass models for now

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/reland_GA_ci branch from 4b286b9 to f1c7654 Compare July 29, 2025 07:28
@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/reland_GA_ci branch from f1c7654 to dffd733 Compare July 29, 2025 15:23
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@cccclai cccclai merged commit ec23e87 into pytorch:main Jul 29, 2025
208 of 210 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants