Skip to content

Conversation

@emmakujala
Copy link
Contributor

@emmakujala emmakujala commented Jul 16, 2025

Logging info about asin being approximated was placed before the if-statement in call_operator resulting in it being triggered for all ops, not just asin.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Logging info about asin being approximated was placed before
the if-statement in call_operator resulting in it being
triggered for all ops, not just asin.

Signed-off-by: Emma Kujala <[email protected]>
Change-Id: Icd743abce99b0173c610fa863f22ad5113726b06
@emmakujala emmakujala requested a review from digantdesai as a code owner July 16, 2025 13:52
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12540

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit f3d2916 with merge base 07c8f0f (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2025
@emmakujala
Copy link
Contributor Author

@pytorchbot label: "partner: arm"

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'label:' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

@emmakujala
Copy link
Contributor Author

@pytorchbot label "ciflow/trunk"

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2025

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@emmakujala
Copy link
Contributor Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jul 16, 2025
@emmakujala
Copy link
Contributor Author

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot bot added the release notes: arm Changes to the ARM backend delegate label Jul 16, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated CI failures

@Sebastian-Larsson Sebastian-Larsson merged commit d6e25e2 into pytorch:main Jul 17, 2025
201 of 206 checks passed
lucylq pushed a commit that referenced this pull request Jul 17, 2025
Logging info about asin being approximated was placed before the
if-statement in call_operator resulting in it being triggered for all
ops, not just asin.

Signed-off-by: Emma Kujala <[email protected]>
@emmakujala emmakujala deleted the fix-logging-info-in-asin-decomp branch July 23, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants