-
Notifications
You must be signed in to change notification settings - Fork 752
Arm backend: Fix logging info in decomposition pass for asin #12540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Fix logging info in decomposition pass for asin #12540
Conversation
Logging info about asin being approximated was placed before the if-statement in call_operator resulting in it being triggered for all ops, not just asin. Signed-off-by: Emma Kujala <[email protected]> Change-Id: Icd743abce99b0173c610fa863f22ad5113726b06
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12540
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit f3d2916 with merge base 07c8f0f ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label: "partner: arm" |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot label "ciflow/trunk" |
|
To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page). This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
@pytorchbot label "partner: arm" |
|
@pytorchbot label "release notes: arm" |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
Sebastian-Larsson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated CI failures
Logging info about asin being approximated was placed before the if-statement in call_operator resulting in it being triggered for all ops, not just asin. Signed-off-by: Emma Kujala <[email protected]>
Logging info about asin being approximated was placed before the if-statement in call_operator resulting in it being triggered for all ops, not just asin.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218