Arm backend: Add sub tensor to match scalar tensors to input data types. #12541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I14fe181345f5c6034c0e230329425f5ba74f4910
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12541
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 1703c56 with merge base 4d7f9ca ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label ciflow/trunk |
Collaborator
Author
|
@pytorchbot label 'partner: arm' |
pytorch-bot
bot
added
the
partner: arm
Collaborator
Author
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
Sebastian-Larsson
approved these changes
Jul 21, 2025
Collaborator
Sebastian-Larsson
left a comment
Sebastian-Larsson
left a comment
There was a problem hiding this comment.
Unrelated CI error
Conarnar
pushed a commit
to Conarnar/executorch
that referenced
this pull request
Jul 25, 2025
…es. (pytorch#12541) Updates existing pass to ensure that x1, x2 are of the same type. This comes from an issue where scalars are not automatically casted to the input dtype unlike mul and add operators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates existing pass to ensure that x1, x2 are of the same type.
This comes from an issue where scalars are not automatically casted to the input dtype unlike mul and add operators.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218