-
Notifications
You must be signed in to change notification settings - Fork 751
Make OS presets only build library #12544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12544
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Pending, 1 Unrelated FailureAs of commit 83fae98 with merge base 1333b36 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
123c91c to
9e98f90
Compare
shoumikhin
approved these changes
Jul 16, 2025
lucylq
reviewed
Jul 16, 2025
lucylq
pushed a commit
that referenced
this pull request
Jul 17, 2025
### Summary I think mixing these different motivations (i.e. pybind vs. ET lib) can causes issues in the future with conflicting flags. For example, pybind always enables `EXECUTORCH_ENABLE_LOGGING` regardless of build mode (#12469). So, I think we should just make the platform presets build ET targeting that platform. ### Test plan CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/binaries
ciflow/trunk
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
release notes: none
Do not include this in the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I think mixing these different motivations (i.e. pybind vs. ET lib) can causes issues in the future with conflicting flags. For example, pybind always enables
EXECUTORCH_ENABLE_LOGGINGregardless of build mode (#12469). So, I think we should just make the platform presets build ET targeting that platform.Test plan
CI