Skip to content

Conversation

@jathu
Copy link
Contributor

@jathu jathu commented Jul 16, 2025

Summary

I think mixing these different motivations (i.e. pybind vs. ET lib) can causes issues in the future with conflicting flags. For example, pybind always enables EXECUTORCH_ENABLE_LOGGING regardless of build mode (#12469). So, I think we should just make the platform presets build ET targeting that platform.

Test plan

CI

@jathu jathu added ciflow/trunk ciflow/binaries release notes: none Do not include this in the release notes labels Jul 16, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12544

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Pending, 1 Unrelated Failure

As of commit 83fae98 with merge base 1333b36 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2025
@jathu jathu force-pushed the jathu/os-pure branch 3 times, most recently from 123c91c to 9e98f90 Compare July 16, 2025 16:59
@jathu jathu requested a review from shoumikhin July 16, 2025 16:59
@jathu jathu marked this pull request as ready for review July 16, 2025 17:00
@jathu jathu merged commit 988435d into main Jul 16, 2025
211 of 214 checks passed
@jathu jathu deleted the jathu/os-pure branch July 16, 2025 21:05
lucylq pushed a commit that referenced this pull request Jul 17, 2025
### Summary

I think mixing these different motivations (i.e. pybind vs. ET lib) can
causes issues in the future with conflicting flags. For example, pybind
always enables `EXECUTORCH_ENABLE_LOGGING` regardless of build mode
(#12469). So, I think we
should just make the platform presets build ET targeting that platform.

### Test plan

CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants