Skip to content

Fix internal tests affected by D77980055 #12554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
masnesral merged 1 commit into from
Jul 18, 2025
Merged

Fix internal tests affected by D77980055 #12554

masnesral merged 1 commit into from
Jul 18, 2025

Conversation

@masnesral
Copy link
Contributor

@masnesral masnesral commented Jul 16, 2025

Summary: Looks like the change to how full_like is decomposed means these tests need some tweaks

Differential Revision: D77981005

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12554

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 073d3b8 with merge base 4456407 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 16, 2025

This pull request was exported from Phabricator. Differential Revision: D77981005

@github-actions
Copy link

github-actions bot commented Jul 16, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

masnesral added a commit to masnesral/executorch that referenced this pull request Jul 16, 2025
@masnesral @facebook-github-bot
Fix internal tests affected by D77980055 (pytorch#12554)
c35d14a 
Summary:

Looks like the change to how full_like is decomposed means these tests need some tweaks

Reviewed By: digantdesai

Differential Revision: D77981005
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 16, 2025

This pull request was exported from Phabricator. Differential Revision: D77981005

masnesral added a commit to masnesral/executorch that referenced this pull request Jul 16, 2025
@masnesral @facebook-github-bot
Fix internal tests affected by D77980055 (pytorch#12554)
0c90cb0 
Summary:

Looks like the change to how full_like is decomposed means these tests need some tweaks

Reviewed By: digantdesai

Differential Revision: D77981005
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 16, 2025

This pull request was exported from Phabricator. Differential Revision: D77981005

masnesral added a commit to masnesral/executorch that referenced this pull request Jul 16, 2025
@masnesral @facebook-github-bot
Fix internal tests affected by D77980055 (pytorch#12554)
4809dea 
Summary:
Pull Request resolved: pytorch#12554

Looks like the change to how full_like is decomposed means these tests need some tweaks

Reviewed By: digantdesai

Differential Revision: D77981005
@masnesral masnesral force-pushed the export-D77981005 branch 2 times, most recently from 4809dea to d75a9fd Compare July 16, 2025 22:30
masnesral added a commit to masnesral/executorch that referenced this pull request Jul 16, 2025
@masnesral @facebook-github-bot
Fix internal tests affected by D77980055 (pytorch#12554)
d75a9fd 
Summary:

Looks like the change to how full_like is decomposed means these tests need some tweaks

Reviewed By: digantdesai

Differential Revision: D77981005
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 16, 2025

This pull request was exported from Phabricator. Differential Revision: D77981005

digantdesai
digantdesai reviewed Jul 16, 2025
View reviewed changes
exir/tests/test_memory_planning.py Outdated
self.assertEqual(
ep.executorch_program.execution_plan[0]
.values[147]
.values[149]
Copy link
Contributor

@digantdesai digantdesai Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this will pass w/o pytorch/pytorch#144765. But if it does, then the test may not care about it in the first place :)

digantdesai
digantdesai reviewed Jul 16, 2025
View reviewed changes
backends/arm/test/passes/test_decompose_cosine_similarity_pass.py Outdated
"executorch_exir_dialects_edge__ops_aten_sum_dim_IntList": 3,
"executorch_exir_dialects_edge__ops_aten_pow_Tensor_Scalar": 2,
"executorch_exir_dialects_edge__ops_aten_full_like_default": 1,
"executorch_exir_dialects_edge__ops_aten_full_default": 1,
Copy link
Contributor

@digantdesai digantdesai Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

digantdesai
digantdesai approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping to unblock.

masnesral added a commit to masnesral/executorch that referenced this pull request Jul 17, 2025
@masnesral @facebook-github-bot
Fix internal tests affected by D77980055 (pytorch#12554)
78fd441 
Summary:

Looks like the change to how full_like is decomposed means these tests need some tweaks

Reviewed By: digantdesai

Differential Revision: D77981005
masnesral added a commit to masnesral/executorch that referenced this pull request Jul 17, 2025
@masnesral @facebook-github-bot
Fix internal tests affected by D77980055 (pytorch#12554)
fe6a1f7 
Summary:

Looks like the change to how full_like is decomposed means these tests need some tweaks

Reviewed By: digantdesai

Differential Revision: D77981005
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 17, 2025

This pull request was exported from Phabricator. Differential Revision: D77981005

@masnesral @facebook-github-bot
Fix internal tests affected by D77980055 (pytorch#12554)
073d3b8 
Summary:
Pull Request resolved: pytorch#12554

Looks like the change to how full_like is decomposed means these tests need some tweaks

Reviewed By: digantdesai

Differential Revision: D77981005
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 17, 2025

This pull request was exported from Phabricator. Differential Revision: D77981005

@masnesral
Copy link
Contributor Author

masnesral commented Jul 18, 2025

AFAICT the test failure is entirely unrelated; it would have to be since I'm just commenting out tests here.

@masnesral
Copy link
Contributor Author

masnesral commented Jul 18, 2025

@pytorchbot merge -i

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 18, 2025

Mergebot is not configured for this repository. Please use the merge button provided by GitHub.

@masnesral masnesral merged commit 9f2b8cd into pytorch:main Jul 18, 2025
551 of 560 checks passed
@masnesral masnesral deleted the export-D77981005 branch July 18, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@masnesral @facebook-github-bot @digantdesai